1756359 - Use fixIterator and replace use of removeItemAt in FilterListDialog

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, task)

Description

[Ian Neal]

Port the relevant parts of:

• Bug 748965 - Convert mail/base/content/FilterListDialog.js and SearchDialog.js to Services.jsm and MailServices.js
• Bug 1113097 - Fix misuse of fixIterator in mail and mailnews.
• Bug 1340947 - Part 2: Use for-of when iterating over fixIterator in mail/
• Bug 1459184 - Port bug 1456611: Replace use of insertItemAt and removeItemAt methods (mail part)

Comment 1

[Ian Neal]

Attachment: 1756359-fld-fixiterator-removeitemat-25312.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.12
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9264764 [details] [diff] [review]
1756359-fld-fixiterator-removeitemat-25312.patch

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/822aafe465ec
Replace use of removeItemAt in FilterListDialog. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/bf2e8751c787241e2e4d63235463ee502930a3d0
Use fixIterator and replace use of removeItemAt in FilterListDialog. r=frg a=frg