1756574 - Variants with empty query string or fragment confuse wptrunner

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

If a test has <meta name=variant content=?> we construct the test id as /path/to/test.html?. But if that's treated as a URL and then normalised we end up with /path/to/test.html. This mismatch isn't handled well by wptrunner or various other components (e.g. the metadata update).

The simplest thing to do is to forbid empty query or fragment parts in a test id and fail to generate the manifest in that case.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1756574 - Remove empty query variant from app-history tests,

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1756574 - Disallow variants with empty query or fragments,

These have a different normalised representation, which confuses various parts of
the infrastructure that assume you can manipulate test ids like URLs

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32995 for changes under testing/web-platform/tests

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d182bd668dcc
Remove empty query variant from app-history tests, r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/4ffc3dd1d29d
Disallow variants with empty query or fragments, r=jdescottes,Ms2ger

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9d568c9b12a
Remove empty query variant from app-history tests, r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/0e15e6e4dd42
Disallow variants with empty query or fragments, r=jdescottes,Ms2ger

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a9d568c9b12a
https://hg.mozilla.org/mozilla-central/rev/0e15e6e4dd42

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot