Intermittent Assertion failure: aResponseTarget, at /builds/worker/workspace/obj-build/dist/include/mozilla/MozPromise.h:502
Categories
(Core :: Widget: Gtk, defect, P5)
Tracking
()
People
(Reporter: intermittent-bug-filer, Assigned: stransky)
References
Details
(Keywords: assertion, intermittent-failure, Whiteboard: [stockwell disable-recommended])
Attachments
(2 files, 1 obsolete file)
Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=368768966&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dt0MZXFCR2iHM8iAPE1rbQ/runs/0/artifacts/public/logs/live_backing.log
[task 2022-02-22T15:29:17.456Z] 15:29:17 INFO - GECKO(5496) | #01: NS_DebugBreak(unsigned int, char const*, char const*, char const*, int) [xpcom/base/nsDebugImpl.cpp:429]
[task 2022-02-22T15:29:17.457Z] 15:29:17 INFO - GECKO(5496) | #02: NS_DispatchToMainThread(already_AddRefed<nsIRunnable>&&, unsigned int) [xpcom/threads/nsThreadUtils.cpp:223]
[task 2022-02-22T15:29:17.457Z] 15:29:17 INFO - GECKO(5496) | #03: NS_DispatchToMainThread(nsIRunnable*, unsigned int) [xpcom/threads/nsThreadUtils.cpp:239]
[task 2022-02-22T15:29:17.458Z] 15:29:17 INFO - GECKO(5496) | #04: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) [layout/base/nsRefreshDriver.cpp:548]
[task 2022-02-22T15:29:17.458Z] 15:29:17 INFO - GECKO(5496) | #05: mozilla::RefreshTimerVsyncDispatcher::NotifyVsync(mozilla::VsyncEvent const&) [widget/VsyncDispatcher.cpp:134]
[task 2022-02-22T15:29:17.459Z] 15:29:17 INFO - GECKO(5496) | #06: mozilla::gfx::VsyncSource::Display::NotifyVsync(mozilla::TimeStamp const&, mozilla::TimeStamp const&) [gfx/thebes/VsyncSource.cpp:121]
[task 2022-02-22T15:29:17.459Z] 15:29:17 INFO - GECKO(5496) | #07: D3DVsyncSource::D3DVsyncDisplay::VBlankLoop() [gfx/thebes/gfxWindowsPlatform.cpp:1678]
[task 2022-02-22T15:29:17.460Z] 15:29:17 INFO - GECKO(5496) | #08: mozilla::detail::RunnableMethodImpl<D3DVsyncSource::D3DVsyncDisplay *,void (D3DVsyncSource::D3DVsyncDisplay::*)(),1,mozilla::RunnableKind::Standard>::Run() [xpcom/threads/nsThreadUtils.h:1203]
[task 2022-02-22T15:29:17.460Z] 15:29:17 INFO - GECKO(5496) | #09: MessageLoop::RunTask(already_AddRefed<nsIRunnable>) [ipc/chromium/src/base/message_loop.cc:455]
[task 2022-02-22T15:29:17.460Z] 15:29:17 INFO - GECKO(5496) | #10: MessageLoop::DoWork() [ipc/chromium/src/base/message_loop.cc:540]
[task 2022-02-22T15:29:17.461Z] 15:29:17 INFO - GECKO(5496) | #11: base::MessagePumpDefault::Run(base::MessagePump::Delegate*) [ipc/chromium/src/base/message_pump_default.cc:35]
[task 2022-02-22T15:29:17.461Z] 15:29:17 INFO - GECKO(5496) | #12: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:325]
[task 2022-02-22T15:29:17.462Z] 15:29:17 INFO - GECKO(5496) | #13: base::Thread::ThreadMain() [ipc/chromium/src/base/thread.cc:187]
[task 2022-02-22T15:29:17.462Z] 15:29:17 INFO - GECKO(5496) | #14: `anonymous namespace'::ThreadFunc(void*) [ipc/chromium/src/base/platform_thread_win.cc:20]
[task 2022-02-22T15:29:17.462Z] 15:29:17 INFO - GECKO(5496) | #15: BaseThreadInitThunk [C:\Windows\System32\KERNEL32.DLL + 0x17034]
[task 2022-02-22T15:29:17.512Z] 15:29:17 INFO - GECKO(5496) | #16: patched_BaseThreadInitThunk(int, void*, void*) [toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp:572]
[task 2022-02-22T15:29:17.512Z] 15:29:17 INFO - GECKO(5496) | #17: RtlUserThreadStart [C:\Windows\SYSTEM32\ntdll.dll + 0x52651]
[task 2022-02-22T15:29:17.513Z] 15:29:17 INFO - GECKO(5496) | Assertion failure: aResponseTarget, at /builds/worker/workspace/obj-build/dist/include/mozilla/MozPromise.h:502
[task 2022-02-22T15:29:17.514Z] 15:29:17 INFO - GECKO(5496) | #01: mozilla::MozPromise<CopyableTArray<bool>,mozilla::ipc::ResponseRejectReason,1>::ThenValueBase::ThenValueBase(nsISerialEventTarget*, char const*) [xpcom/threads/MozPromise.h:502]
[task 2022-02-22T15:29:17.514Z] 15:29:17 INFO - GECKO(5496) | #02: nsFrameLoader::RequestFinalTabStateFlush() [dom/base/nsFrameLoader.cpp:3290]
[task 2022-02-22T15:29:17.515Z] 15:29:17 INFO - GECKO(5496) | #03: nsFrameLoader::StartDestroy(bool) [dom/base/nsFrameLoader.cpp:1884]
[task 2022-02-22T15:29:17.515Z] 15:29:17 INFO - GECKO(5496) | #04: mozilla::dom::XULFrameElement::DestroyContent() [dom/xul/XULFrameElement.cpp:178]
[task 2022-02-22T15:29:17.516Z] 15:29:17 INFO - GECKO(5496) | #05: mozilla::dom::FragmentOrElement::DestroyContent() [dom/base/FragmentOrElement.cpp:1083]
[task 2022-02-22T15:29:17.516Z] 15:29:17 INFO - GECKO(5496) | #06: mozilla::dom::Document::Destroy() [dom/base/Document.cpp:11350]
[task 2022-02-22T15:29:17.517Z] 15:29:17 INFO - GECKO(5496) | #07: nsDocumentViewer::Destroy() [layout/base/nsDocumentViewer.cpp:1750]
[task 2022-02-22T15:29:17.517Z] 15:29:17 INFO - GECKO(5496) | #08: nsDocShell::Destroy() [docshell/base/nsDocShell.cpp:4583]
[task 2022-02-22T15:29:17.518Z] 15:29:17 INFO - GECKO(5496) | #09: nsWebBrowser::SetDocShell(nsDocShell*) [toolkit/components/browser/nsWebBrowser.cpp:1125]
[task 2022-02-22T15:29:17.518Z] 15:29:17 INFO - GECKO(5496) | #10: nsWebBrowser::InternalDestroy() [toolkit/components/browser/nsWebBrowser.cpp:178]
[task 2022-02-22T15:29:17.518Z] 15:29:17 INFO - GECKO(5496) | #11: nsWebBrowser::Destroy() [toolkit/components/browser/nsWebBrowser.cpp:858]
[task 2022-02-22T15:29:17.519Z] 15:29:17 INFO - GECKO(5496) | #12: static BrowserDestroyer::Destroy(nsIWebBrowser*) [xpfe/appshell/nsAppShellService.cpp:327]
[task 2022-02-22T15:29:17.519Z] 15:29:17 INFO - GECKO(5496) | #13: static nsContentUtils::AddScriptRunner(already_AddRefed<nsIRunnable>) [dom/base/nsContentUtils.cpp:5756]
[task 2022-02-22T15:29:17.520Z] 15:29:17 INFO - GECKO(5496) | #14: WindowlessBrowser::~WindowlessBrowser() [xpfe/appshell/nsAppShellService.cpp:376]
[task 2022-02-22T15:29:17.520Z] 15:29:17 INFO - GECKO(5496) | #15: WindowlessBrowser::Release() [xpfe/appshell/nsAppShellService.cpp:387]
[task 2022-02-22T15:29:17.520Z] 15:29:17 INFO - GECKO(5496) | #16: mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::PopLastN(unsigned int) [mfbt/SegmentedVector.h:246]
[task 2022-02-22T15:29:17.521Z] 15:29:17 INFO - GECKO(5496) | #17: static mozilla::dom::DeferredFinalizerImpl<nsISupports>::DeferredFinalize(unsigned int, void*) [dom/bindings/BindingUtils.h:2751]
[task 2022-02-22T15:29:17.521Z] 15:29:17 INFO - GECKO(5496) | #18: mozilla::IncrementalFinalizeRunnable::ReleaseNow(bool) [xpcom/base/CycleCollectedJSRuntime.cpp:1720]
[task 2022-02-22T15:29:17.522Z] 15:29:17 INFO - GECKO(5496) | #19: mozilla::CycleCollectedJSRuntime::FinalizeDeferredThings(mozilla::CycleCollectedJSContext::DeferredFinalizeType) [xpcom/base/CycleCollectedJSRuntime.cpp:1797]
[task 2022-02-22T15:29:17.522Z] 15:29:17 INFO - GECKO(5496) | #20: mozilla::CycleCollectedJSRuntime::OnGC(JSContext*, JSGCStatus, JS::GCReason) [xpcom/base/CycleCollectedJSRuntime.cpp:1878]
[task 2022-02-22T15:29:17.523Z] 15:29:17 INFO - GECKO(5496) | #21: js::gc::GCRuntime::maybeCallGCCallback(JSGCStatus, JS::GCReason) [js/src/gc/GC.cpp:3619]
[task 2022-02-22T15:29:17.523Z] 15:29:17 INFO - GECKO(5496) | #22: js::gc::GCRuntime::gcCycle(bool, js::SliceBudget const&, JS::GCReason) [js/src/gc/GC.cpp:3696]
[task 2022-02-22T15:29:17.523Z] 15:29:17 INFO - GECKO(5496) | #23: js::gc::GCRuntime::collect(bool, js::SliceBudget const&, JS::GCReason) [js/src/gc/GC.cpp:3874]
[task 2022-02-22T15:29:17.524Z] 15:29:17 INFO - GECKO(5496) | #24: js::gc::GCRuntime::gc(JS::GCOptions, JS::GCReason) [js/src/gc/GC.cpp:3952]
[task 2022-02-22T15:29:17.524Z] 15:29:17 INFO - GECKO(5496) | #25: JS::NonIncrementalGC(JSContext*, JS::GCOptions, JS::GCReason) [js/src/gc/GCAPI.cpp:283]
[task 2022-02-22T15:29:17.525Z] 15:29:17 INFO - GECKO(5496) | #26: nsCycleCollector::FixGrayBits(bool, TimeLog&) [xpcom/base/nsCycleCollector.cpp:3276]
[task 2022-02-22T15:29:17.525Z] 15:29:17 INFO - GECKO(5496) | #27: nsCycleCollector::BeginCollection(mozilla::CCReason, ccIsManual, nsICycleCollectorListener*) [xpcom/base/nsCycleCollector.cpp:3579]
[task 2022-02-22T15:29:17.526Z] 15:29:17 INFO - GECKO(5496) | #28: nsCycleCollector::Collect(mozilla::CCReason, ccIsManual, js::SliceBudget&, nsICycleCollectorListener*, bool) [xpcom/base/nsCycleCollector.cpp:3410]
[task 2022-02-22T15:29:17.526Z] 15:29:17 INFO - GECKO(5496) | #29: nsCycleCollector::ShutdownCollect() [xpcom/base/nsCycleCollector.cpp:3351]
[task 2022-02-22T15:29:17.527Z] 15:29:17 INFO - GECKO(5496) | #30: nsCycleCollector::Shutdown(bool) [xpcom/base/nsCycleCollector.cpp:3647]
[task 2022-02-22T15:29:17.527Z] 15:29:17 INFO - GECKO(5496) | #31: nsCycleCollector_shutdown(bool) [xpcom/base/nsCycleCollector.cpp:3963]
[task 2022-02-22T15:29:17.528Z] 15:29:17 INFO - GECKO(5496) | #32: mozilla::ShutdownXPCOM(nsIServiceManager*) [xpcom/build/XPCOMInit.cpp:727]
[task 2022-02-22T15:29:17.528Z] 15:29:17 INFO - GECKO(5496) | #33: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:2049]
[task 2022-02-22T15:29:17.528Z] 15:29:17 INFO - GECKO(5496) | #34: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5933]
[task 2022-02-22T15:29:17.529Z] 15:29:17 INFO - GECKO(5496) | #35: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5975]
[task 2022-02-22T15:29:17.529Z] 15:29:17 INFO - GECKO(5496) | #36: NS_internal_main(int, char**, char**) [browser/app/nsBrowserApp.cpp:395]
[task 2022-02-22T15:29:17.530Z] 15:29:17 INFO - GECKO(5496) | #37: wmain(int, wchar_t**) [toolkit/xre/nsWindowsWMain.cpp:147]
[task 2022-02-22T15:29:17.530Z] 15:29:17 INFO - GECKO(5496) | #38: __scrt_common_main_seh() [/builds/worker/workspace/obj-build/browser/app/d:/agent/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
[task 2022-02-22T15:29:17.531Z] 15:29:17 INFO - GECKO(5496) | #39: BaseThreadInitThunk [C:\Windows\System32\KERNEL32.DLL + 0x17034]
[task 2022-02-22T15:29:17.531Z] 15:29:17 INFO - GECKO(5496) | #40: RtlUserThreadStart [C:\Windows\SYSTEM32\ntdll.dll + 0x52651]
[task 2022-02-22T15:29:17.531Z] 15:29:17 INFO - TEST-INFO | Main app process: exit 1
[task 2022-02-22T15:29:17.532Z] 15:29:17 INFO - Buffered messages logged at 15:29:06
[task 2022-02-22T15:29:17.532Z] 15:29:17 INFO - add_task | Entering test
[task 2022-02-22T15:29:17.532Z] 15:29:17 INFO - Extension loaded
[task 2022-02-22T15:29:17.533Z] 15:29:17 INFO - Extension loaded
[task 2022-02-22T15:29:17.533Z] 15:29:17 INFO - Buffered messages finished
[task 2022-02-22T15:29:17.534Z] 15:29:17 ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_streamfilter_multiple.html | application terminated with exit code 1
Comment hidden (Intermittent Failures Robot) |
Comment 2•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 3•2 years ago
|
||
treeherder |
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=374281899&repo=mozilla-central
Comment hidden (Intermittent Failures Robot) |
Comment 5•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 6•1 year ago
|
||
treeherder |
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=402663068&repo=autoland
Updated•1 year ago
|
Comment 7•1 year ago
•
|
||
This became frequent when Bug 1351231 landed. backfill range and retriggers
Bug 1351231 was backed out, backout link here, because of this I will change the bug summary.
If this becomes frequent again please change the bug summary back.
Thank you!
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 10•1 year ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 11•7 months ago
|
||
treeherder |
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=432102694&repo=autoland
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 18•5 months ago
|
||
Update:
There have been 53 failures within the last 7 days, all on linux2204-64-wayland debug.
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=435944219&repo=mozilla-central&lineNumber=7657
[task 2023-11-12T10:39:50.737Z] 10:39:50 INFO - GECKO(4690) | [Parent 4690, Main Thread] WARNING: '!top', file /builds/worker/checkouts/gecko/dom/xul/MenuBarListener.cpp:99
[task 2023-11-12T10:39:51.070Z] 10:39:51 INFO - GECKO(4690) | Assertion failure: aResponseTarget, at /builds/worker/workspace/obj-build/dist/include/mozilla/MozPromise.h:505
[task 2023-11-12T10:39:51.093Z] 10:39:51 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2023-11-12T10:40:15.701Z] 10:40:15 INFO - GECKO(4690) | #01: mozilla::MozPromise<RefPtr<_GDBusProxy>, mozilla::UniquePtr<_GError, mozilla::GFreeDeleter>, true>::ThenValueBase::ThenValueBase(nsISerialEventTarget*, char const*) [xpcom/threads/MozPromise.h:505]
[task 2023-11-12T10:40:15.703Z] 10:40:15 INFO - GECKO(4690) | #02: WakeLockTopic::DBusUninhibitScreensaver(char const*, char const*, char const*, char const*) [widget/gtk/WakeLockListener.cpp:353]
[task 2023-11-12T10:40:15.704Z] 10:40:15 INFO - GECKO(4690) | #03: WakeLockTopic::SendUninhibit() [widget/gtk/WakeLockListener.cpp:0]
[task 2023-11-12T10:40:15.704Z] 10:40:15 INFO - GECKO(4690) | #04: WakeLockTopic::~WakeLockTopic() [widget/gtk/WakeLockListener.cpp:159]
[task 2023-11-12T10:40:15.708Z] 10:40:15 INFO - GECKO(4690) | #05: WakeLockTopic::Release() [widget/gtk/WakeLockListener.cpp:96]
[task 2023-11-12T10:40:15.710Z] 10:40:15 INFO - GECKO(4690) | #06: nsTHashtable<nsBaseHashtableET<nsStringHashKey, RefPtr<WakeLockTopic> > >::s_ClearEntry(PLDHashTable*, PLDHashEntryHdr*) [xpcom/ds/nsTHashtable.h:720]
[task 2023-11-12T10:40:15.710Z] 10:40:15 INFO - GECKO(4690) | #07: PLDHashTable::~PLDHashTable() [xpcom/ds/PLDHashTable.cpp:292]
[task 2023-11-12T10:40:15.710Z] 10:40:15 INFO - GECKO(4690) | #08: WakeLockListener::Release() [widget/gtk/WakeLockListener.cpp:49]
[task 2023-11-12T10:40:15.713Z] 10:40:15 INFO - GECKO(4690) | #09: mozilla::xpcom::StaticComponents::Shutdown() [s3:gecko-generated-sources:21d49892da0b2a89e6141009d43cb7a136354b8a95265a6b104c289f064f154266a6cdb2560fcbd265e01276d653a1ec1ccd1c11e0936aa1ed7b2f63bb23f75e/xpcom/components/StaticComponents.cpp::13323]
[task 2023-11-12T10:40:15.714Z] 10:40:15 INFO - GECKO(4690) | #10: nsComponentManagerImpl::Shutdown() [xpcom/components/nsComponentManager.cpp:566]
[task 2023-11-12T10:40:15.714Z] 10:40:15 INFO - GECKO(4690) | #11: mozilla::ShutdownXPCOM(nsIServiceManager*) [xpcom/build/XPCOMInit.cpp:711]
[task 2023-11-12T10:40:15.716Z] 10:40:15 INFO - GECKO(4690) | #12: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:1990]
[task 2023-11-12T10:40:15.716Z] 10:40:15 INFO - GECKO(4690) | #13: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5911]
[task 2023-11-12T10:40:15.717Z] 10:40:15 INFO - GECKO(4690) | #14: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5946]
[task 2023-11-12T10:40:15.728Z] 10:40:15 INFO - GECKO(4690) | #15: ??? [/home/ubuntu/tasks/task_169978048271421/build/application/firefox/firefox + 0x3ddda]
[task 2023-11-12T10:40:15.732Z] 10:40:15 INFO - GECKO(4690) | #16: ??? [/lib/x86_64-linux-gnu/libc.so.6 + 0x29d90]
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | #17: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x29e40]
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | #18: ??? [/home/ubuntu/tasks/task_169978048271421/build/application/firefox/firefox + 0x3d919]
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | #19: ??? (???:???)
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | ExceptionHandler::GenerateDump cloned child 7168
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2023-11-12T10:40:15.735Z] 10:40:15 INFO - GECKO(4690) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2023-11-12T10:40:15.736Z] 10:40:15 INFO - TEST-INFO | Main app process: exit 11
[task 2023-11-12T10:40:15.736Z] 10:40:15 INFO - Buffered messages finished
[task 2023-11-12T10:40:15.737Z] 10:40:15 INFO - runtests.py | Application ran for: 0:21:06.367925
Comment 19•5 months ago
|
||
Hi Jim! Can you please take a look at this? Or maybe redirect the needinfo to someone that works with wayland specifically?
Thank you!
Comment hidden (Intermittent Failures Robot) |
Comment 21•5 months ago
|
||
Seems wakelock specific, not sure this has anything to do with wayland or media. When the wakelock object gets destroyed, it calls 'WakeLockTopic::DBusUninhibitScreensaver'. (The stacks have changed since the original bug was filed.)
Gian-Carlo, any ideas on what to do with this? The failure rate is pretty bad, but not top ten.
Updated•5 months ago
|
Updated•5 months ago
|
Comment 22•5 months ago
|
||
I guess it's not actually regressed by that bug, as the failures go back 2 years. That's just the bug that changed the stack.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 24•5 months ago
|
||
We use GetCurrentSerialEventTarget() to get serial so it's possible it fails and return nullptr as we're already in shutdown?
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•5 months ago
|
Assignee | ||
Comment 28•5 months ago
|
||
It's because we call WakeLockTopic::UninhibitFreeDesktopPortal() in shutdown phase.
GetCurrentSerialEventTarget() returns nullptr because NS_GetCurrentThread() returns nullptr as MainThread is already suspended. Component shutdown (WakeLockTopic) is called after ShutdownMainThread() in ShutdownXPCOM().
Assignee | ||
Comment 29•5 months ago
|
||
Comment 30•5 months ago
|
||
This matches what macOS and Windows do, and should clean up the wake
lock stuff early enough to not hit this issue.
Updated•5 months ago
|
Updated•5 months ago
|
Comment 31•5 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08990bc135c9 Make GTK wake lock lifetime more similar to other desktop platforms. r=stransky
Comment 32•5 months ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/e14c826ee0f3 Fix non-unified build.
Comment 33•5 months ago
|
||
As it might bring the lock "back to life", which is wrong, causing
assertions. Instead use shutdown (the listener destructor) to do that.
Comment 34•5 months ago
|
||
Martin mind sanity-checking comment 33? It's loosely based on comment 29 (just at a more precise time). It was causing autoland failures (linked in the commit message). I decided to land it to stop turning the Wayland jobs orange since it's late in your day.
Comment 35•5 months ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/84d336146c88 Don't SendUnhibit() on the WakeLockTopic destructor. rpending=stransky
Comment 36•5 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/08990bc135c9
https://hg.mozilla.org/mozilla-central/rev/e14c826ee0f3
https://hg.mozilla.org/mozilla-central/rev/84d336146c88
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 38•5 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #34)
Martin mind sanity-checking comment 33? It's loosely based on comment 29 (just at a more precise time). It was causing autoland failures (linked in the commit message). I decided to land it to stop turning the Wayland jobs orange since it's late in your day.
LGTM, Thanks.
Comment hidden (Intermittent Failures Robot) |
Comment 40•5 months ago
|
||
fwiw, this breaks --disable-dbus
builds:
93:47.11 In file included from Unified_cpp_widget_gtk1.cpp:110:
93:47.12 /home/landry/src/m-c/widget/gtk/nsAppShell.cpp:425:5: error: use of undeclared identifier 'AddScreenWakeLockListener'
93:47.12 AddScreenWakeLockListener();
93:47.12 ^
93:47.40 /home/landry/src/m-c/widget/gtk/nsAppShell.cpp:431:5: error: use of undeclared identifier 'RemoveScreenWakeLockListener'
93:47.40 RemoveScreenWakeLockListener();
93:47.40 ^
the methods are defined within MOZ_ENABLE_DBUS
but called outside of it.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 42•5 months ago
|
||
(In reply to Landry Breuil (:gaston) from comment #40)
fwiw, this breaks
--disable-dbus
builds:93:47.11 In file included from Unified_cpp_widget_gtk1.cpp:110: 93:47.12 /home/landry/src/m-c/widget/gtk/nsAppShell.cpp:425:5: error: use of undeclared identifier 'AddScreenWakeLockListener' 93:47.12 AddScreenWakeLockListener(); 93:47.12 ^ 93:47.40 /home/landry/src/m-c/widget/gtk/nsAppShell.cpp:431:5: error: use of undeclared identifier 'RemoveScreenWakeLockListener' 93:47.40 RemoveScreenWakeLockListener(); 93:47.40 ^
the methods are defined within
MOZ_ENABLE_DBUS
but called outside of it.
Please file a new bug for it.
Comment 43•5 months ago
|
||
done in bug #1866734
Updated•5 months ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Description
•