1756718 - When showing picture-in-picture player controls, move subtitles up if they would overlap

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[:Gijs (he/him)]

Right now the text can overlap with the player controls. It'd be nice if we moved the text up if this were to happen, perhaps with an animation (if the user hasn't enabled reduced motion).

Comment 1

[kpatenio]

Attachment: Bug 1756718 - move pip texttracks when pip player controls appear to avoid overlap. r=#pip-reviewers!,mhowell!

Comment 2

[kpatenio]

Patch is still WIP. Considering that the pip text tracks container and video controls are both managed by different processes and different style sheets, making the text tracks container move to avoid overlap requires passing data from the parent to the child process. (If anyone has ideas for a better solution, I'd love to know).

For now, we try to detect overlap and mouse position over the pip window, and move the text tracks container depending on if we hover on or hover away from the pip window. There is still more work to do including:

• moving text tracks when video controls are focused on. (ex. keyboard navigation)
• supporting multiple pip windows. Right now, it only works on one. (I will need to revise my patch a bit)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c679372f01be
move pip texttracks when pip player controls appear to avoid overlap. r=mhowell,pip-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c679372f01be

Comment 5

[Daniel Bodea [:danibodea]]

This fix was verified in the latest Nightly v100.0a1 from 2022-03-14 on Windows 10, Ubuntu 20/22 and Mac OS 12.