1756730 - Crash when fetching text attributes while loading Microsoft Docs pages with CTW + NVDA

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

STR (with the NVDA screen reader):

1. Enable CTW.
2. Load this page: https://docs.microsoft.com/en-us/dotnet/standard/async-in-depth
   • Actual: Crash!
   • Expected: No crash.

There seems to be a text leaf with no text attributes. Perhaps NVDA poked the tree before the cache message arrived? I'm not really sure why this happens. In any case, it doesn't hurt to null check attributes.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1756730: Null check atributes in TextLeafPoint::FindTextAttrsStart.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1730096

Comment 3

[James Teh [:Jamie]]

:dmeehan, this code is behind a pref which will still be disabled by default in 99. Do you still think this needs to be tracked for 99?

Comment 4

[Donal Meehan [:dmeehan]]

(In reply to James Teh [:Jamie] from comment #3)

:dmeehan, this code is behind a pref which will still be disabled by default in 99. Do you still think this needs to be tracked for 99?

Thanks :jamie for the info - I will remove tracking for 99.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0ce0d918602
Null check atributes in TextLeafPoint::FindTextAttrsStart. r=morgan

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f0ce0d918602