1756755 - ATK getActionNameCB returning localised action instead of unlocalised

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[James Teh [:Jamie]]

Reported on Matrix. After bug 1748749, getActionNameCB now calls ActionDescriptionAt instead of ActionNameAt. This results in the localised action being returned instead of the unlocalised action, which breaks stuff related to clickables in Orca for non-English users.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1748749

Comment 2

[Pascal Chevrel:pascalc]

Eitan, your patch created this regression, how feasible would it be to have a fix for our last beta or for RC on Monday? Thanks

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1756755 - Return unlocalized action name for atk_action_get_name. r?morgan

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a194194d4a2
Return unlocalized action name for atk_action_get_name. r=morgan

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0a194194d4a2

Comment 6

[Pascal Chevrel:pascalc]

Please request uplift now if you want this fix in 98, thanks.

Comment 7

[James Teh [:Jamie]]

Comment on attachment 9265193 [details]
Bug 1756755 - Return unlocalized action name for atk_action_get_name. r?morgan

Beta/Release Uplift Approval Request

• User impact if declined: Orca screen reader users won't be able to navigate to "clickable" elements.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward patch which is isolated to a very specific area.
• String changes made/needed:

Comment 8

[James Teh [:Jamie]]

I normally wouldn't hijack an uplift request, but I wanted to get this in ASAP.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9265193 [details]
Bug 1756755 - Return unlocalized action name for atk_action_get_name. r?morgan

Approved for landing on the beta branch before the beta->release merge. We are out of beta so this will land directly in our release candidate build shipping on Monday

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/930efedb8f94

Comment 11

[Peter Vágner]

Thank you! It's working as expected when testing with Firefox 99.0a1 2022-02-25