1756789 - MozContainerWayland internals are not thread safe

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

MozContainerWayland internals are not thread safe as it's proven in Bug 1754789.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1756789 Protect MozContainerWayland internals by container_lock r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3babaf36e54a
Protect MozContainerWayland internals by container_lock r=emilio

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages on MozContainerWayland.cpp

Backout link : https://hg.mozilla.org/integration/autoland/rev/2850940e219a1b1100151c7a178f4a4525cea2b2

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&duplicate_jobs=visible&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=3babaf36e54a008f0c598b5f8bc8010fd1c0f1ae&selectedTaskRun=SHBEGh3URCe0EsoGlzcSKw.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=369054652&repo=autoland&lineNumber=35997

Failure line : /builds/worker/checkouts/gecko/widget/gtk/MozContainerWayland.cpp:204:38: error: expected ';' after do/while statement

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1756789 Add proof of lock to MozContainerWayland internals r?emilio

Depends on D139488

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Updated, thanks.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=15992fac67a176ccc36f907fa5a8eb90e2643700

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/036fee9bf223
Protect MozContainerWayland internals by container_lock r=emilio
https://hg.mozilla.org/integration/autoland/rev/aba90130666a
Add proof of lock to MozContainerWayland internals r=emilio

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/036fee9bf223
https://hg.mozilla.org/mozilla-central/rev/aba90130666a

Comment 11

[Viktor Jägersküpper]

Looking at the crash statistics (now also tracked in bug 1757568), it seems that the changes from this bug lead to significantly more crashes. Since this is already affecting Firefox 99 (current beta), would it be better to backout the changes in version 99?