Closed Bug 1756877 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32955 - InterpolableLength::CreateLength should create a fixed length when without percentage

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32955 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32955
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

InterpolableLength::CreateLength should create a fixed length when without percentage

When an InterpolableLength is an expression without percentage, it can
still create a fixed length when a CSSToLengthConversionData is
provided.

This patch fixes the bug that an unresolved length (represented as an
expression with pixels, percentages and operations) is returned in this
situation.

Fixed: 1299361
Change-Id: Ib9ca8c465a495fdd0d1d00f5b0d8b6f3b62c5d02
Reviewed-on: https://chromium-review.googlesource.com/3485581
WPT-Export-Revision: 7175cf70d34ca86e00e77667d5524653899046f0

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 316 subtests

Status Summary

Firefox

OK : 1
PASS: 316

Chrome

OK : 1
PASS: 304
FAIL: 12

Safari

OK : 1
PASS: 316

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab6ce25e8771 [wpt PR 32955] - InterpolableLength::CreateLength should create a fixed length when without percentage, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ab6ce25e8771

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.