1756900 - Trim down default PDF viewer telemetry.

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, enhancement, P3)

Description

[Nick Rishel [:nrishel]]

Follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=1742674.

After we have an understanding of what PDF viewers are commonly set to default, we need to trim down to a set of observed viewers. This will largely follow what already exists for default browsers.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Romain: would you like to take a crack at preparing the top N list from the WDBA default PDF handler data (per looker)? It's clear some of these need to be grouped. Perhaps we keep groups that amount to >1% of the pings and see how many that is?

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

While we're here, it would be helpful to trim whitespace from the raw PDF handler string.

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Also while we're here, perhaps we could track down why we're getting null at least 10% of the time (for Firefox 105, so we should be fishing the PDF default).

Comment 4

[Nick Rishel [:nrishel]]

(In reply to Nick Alexander :nalexander [he/him] from comment #3)

Also while we're here, perhaps we could track down why we're getting null at least 10% of the time (for Firefox 105, so we should be fishing the PDF default).

I believe we chased this down to an error when inspecting the data - search included FF versions prior to the telemetry being added.

Comment 5

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Worth noting that I did a lot of the relevant labour in this query; we could implement that normalize_pdf_default and be done here.

Comment 6

[Nick Rishel [:nrishel]]

The "Other" category in that query is still fairly large, probably worth a round of finding trends in it.

Comment 8

[Shridhar Shatrughan]

Attachment: Bug 1756900 - Modify functionality to collect values for known default PDF handlers, instead of arbitrary ones. r=bytesized

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 10

[Nick Rishel [:nrishel]]

Attachment: Bug 1756900 - Pre: Simplify error handling and make explicit the string for unknown browsers in DefaultBrowser.cpp. r=bytesized

Comment 11

[Nick Rishel [:nrishel]]

Comment on attachment 9351883 [details]
Bug 1756900 - Modify functionality to collect values for known default PDF handlers, instead of arbitrary ones. r=bytesized

Request for Data Collection Renewal

1. Provide a link to the initial Data Collection Review Request for this collection.
   https://bugzilla.mozilla.org/show_bug.cgi?id=1742674

2. When will this collection now expire?
   Never

3. Why was the initial period of collection insufficient?
   Initial collection was intended as a precursor to determine what we wanted to track. Now that we have that data we are trimming it down to better match our lean data policy.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9931a2d3477
Pre: Simplify error handling and make explicit the string for unknown browsers in DefaultBrowser.cpp. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/07fec736c4e7
Modify functionality to collect values for known default PDF handlers, instead of arbitrary ones. r=bytesized

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f9931a2d3477
https://hg.mozilla.org/mozilla-central/rev/07fec736c4e7

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey, sorry, was at a work week and then sick most of this week. Not a big deal in this particular case, but note that, in general, the data-review should be approved before landing. You can ping the data-stewards channel on matrix if you don't get a response within 24 hours and someone else should be able to help with the review. Looking at this now.

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9351883 [details]
Bug 1756900 - Modify functionality to collect values for known default PDF handlers, instead of arbitrary ones. r=bytesized

data-review+

1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

2. Is the data collection covered by the existing Firefox Privacy Notice?

Yes