Closed Bug 1756912 Opened 1 year ago Closed 5 months ago

Custom test failure formatting for eslint failures omits actual and expected values

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Platform:
Desktop
All
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: Gijs, Assigned: standard8)

Details

Attachments

(1 file)

Bug 1756912 - Add detailed error output for eslint-plugin-mozilla tests. r?Gijs
48 bytes, text/x-phabricator-request
Details | Review

This formatter: https://searchfox.org/mozilla-central/rev/152a28cc2a64a8efefba2160550e14987b943b74/tools/lint/eslint/eslint-plugin-mozilla/reporters/mozilla-format.js#37

doesn't include both actual+expected values, so it leads to test failure output that looks like this:

TEST-UNEXPECTED-FAIL | no-addtask-setup.js | add_task(function setup() {}); | Output is incorrect.

which is unhelpful as it leaves you guessing what the difference was between what we expected and what we actually got.

X-ref https://github.com/eslint/eslint/issues/5917 where this was originally filed in eslint itself (but that ticket is closed, suggesting it is fixed with the default formatters).

Product: Firefox Build System → Developer Infrastructure
Assignee: nobody → standard8
Severity: -- → N/A
Priority: -- → P3
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/304308d24ffe
Add detailed error output for eslint-plugin-mozilla tests. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/304308d24ffe

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.