1756941 - ObjectActor#_getOwnPropertyLength is wasteful

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

We're using DebuggerObject#getOwnPropertyNames to only check the length of the returned array afterward (devtools/server/actors/object.js#207)

We can probably have a dedicate DebuggerObject method to return the length instead.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1756941 - Add DebuggerObject#getOwnPropertiesLength. r=mgaudet.

This new method is being used in DevTools code to replace the usage
that was made of getOwnPropertyNames only to retrieve the length
property of the returned array.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e6883d3dc73
Add DebuggerObject#getOwnPropertiesLength. r=mgaudet.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1756941 - Rename getOwnPropertiesLength into getOwnPropertyNamesLength. r=jandem

Depends on D139709

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46af5ae14b3d
Rename getOwnPropertiesLength into getOwnPropertyNamesLength. r=jandem

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e6883d3dc73

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/46af5ae14b3d