1756973 - NativeAudioCallback threads are not unregistered with the profiler when they no longer exist

Status: NEW

(Core :: Audio/Video: cubeb, defect, P3)

Description

[Florian Quèze [:florian]]

I can reproduce this easily by going to youtube, playing and pausing a video multiple times.

Example profile: https://share.firefox.dev/3sgEcVm

We can see in the profile when the thread stops existing as the profiler fails to sample it when it no longer exists.

I tried putting a printf in https://searchfox.org/mozilla-central/rev/8efeb8af3abb331df65c424ea79bab073140f173/dom/media/AudioThreadRegistry.h#57 and never saw it appear in my terminal.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647717

Comment 2

[Paul Adenot (:padenot)]

We'll "fix" this by using AudioIPC, most probably. There is no way to unregister a thread from a different thread, (is there, Gerald? I haven't found a way to do this?), so we can't really do this in the general case.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647717

Comment 4

[C.M.Chang[:chunmin]]

Besides AudioStream, we have the same problem in GraphDriver and AudioInputSource as well.