1757019 - Text used in long tab titles are blurry with specific Themes after landing patches from bug #1749380

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Text used in long tab titles are blurry with specific Themes after landing patches from bug #1749380.

Regression range pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6f1243c3ba45a4ad3cfd1cacdbf12ad377b4a81&tochange=fc2b3d6448bcc3575fffb1abc923e7e703aeef54

mozillaregression-GUI points that regression is caused by:
Narrowed integration regression window from [31dcf64c, fc2b3d64] (3 builds) to [c6f1243c, fc2b3d64] (2 builds) (~1 steps left)
Bug 1749380 - Part 2 - Performance and quality fixes for part 1. r=gfx-reviewers,nical

Differential Revision:
https://phabricator.services.mozilla.com/D138982

Steps to reproduce:

1. Open latest Mozilla Firefox Nighty 99.0a1 (2022-02-24) (64-bit)
2. Open https://addons.mozilla.org/pl/firefox/addon/virtualfox/
3. Install "Virtualfox" Theme
4. Notice that text used in long tab titles are blurry

Observed results:
Text used in long tab titles are blurry in Mozilla Firefox with specific Themes.

Expected results:
Text is always sharp and clear in Mozilla Firefox.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good.png

Comment 3

[Scott [:thecount] Downe]

I can reproduce this.

I'm looking into this, to see how my patch could have caused this.

Comment 4

[Scott [:thecount] Downe]

My investigation pointed to bug 1756008 and commit https://phabricator.services.mozilla.com/D139440 being the regression.

Thoughts?

Comment 5

[Jonathan Kew [:jfkthame]]

The bug number and phab revision in comment 4 don't seem to correspond at all...?

Comment 6

[Scott [:thecount] Downe]

My bad, wrong copy/paste.

I updated the comment, should have been https://phabricator.services.mozilla.com/D139440

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Odd, now mozillaregression-GUI points me to :

2022-02-24T19:56:59.115000: INFO : Narrowed integration regression window from [31dcf64c, fc2b3d64] (3 builds) to [c6f1243c, fc2b3d64] (2 builds) (~1 steps left)
2022-02-24T19:56:59.135000: DEBUG : Starting merge handling...
2022-02-24T19:56:59.135000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=fc2b3d6448bcc3575fffb1abc923e7e703aeef54&full=1
2022-02-24T19:56:59.135000: DEBUG : redo: attempt 1/3
2022-02-24T19:56:59.135000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?> > changeset=fc2b3d6448bcc3575fffb1abc923e7e703aeef54&full=1',), kwargs: {}, attempt #1
2022-02-24T19:56:59.138000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2022-02-24T19:57:00.724000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?> > changeset=fc2b3d6448bcc3575fffb1abc923e7e703aeef54&full=1 HTTP/1.1" 200 None
2022-02-24T19:57:00.751000: DEBUG : Found commit message:
Bug 1749380 - Part 2 - Performance and quality fixes for part 1. r=gfx-reviewers,nical

• Add support for local scale factors to a surface, allowing it to
  be rasterized in root coordinate space. This allows snapping to
  work across surfaces where the surface transform is a fractional
  offset.

• Calculate scaling factors per rasterized surface and propagate
  them. Ensures correct scale factor calculations when dealing with
  nested preserve-3d contexts with 90-degree axis rotations.

• Support determining exact surface device rect for 2d surfaces
  with fractional surface transforms.

• Fix line decoration cache key size calculations based on world
  scaling factor.

• Remove get_clipped_device_rect usage for calculating clip-mask
  surface allocations, use surface.get_surface_rect instead. The
  prior method doesn't correctly account for expanded local regions
  from the current dirty rect, resulting in invalidation issues in
  some animated edge cases. Also unifies the way clip-mask surface
  allocations work with the way general render target surface
  allocations work.

Differential Revision: https://phabricator.services.mozilla.com/D138982

I tested it 3 times now, so I'm hoping that it's proper now. I'm very sorry for the commotion.

Comment 8

[Jonathan Kew [:jfkthame]]

Agreed - I can reproduce this locally (on macOS, fwiw), and for me also, mozregression points to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6f1243c3ba45a4ad3cfd1cacdbf12ad377b4a81&tochange=fc2b3d6448bcc3575fffb1abc923e7e703aeef54, which is bug 1749380.

Glenn, can you take a look?

Comment 9

[Glenn Watson [:gw]]

I haven't been able to reproduce yet, it might depend on resolution / dpi / platform etc. Could you paste what your about:support contains and also a specific URL that it reproduces on for you?

Comment 10

[Jonathan Kew [:jfkthame]]

For me, it reproduces in current Nightly on macOS on a low-dpi display attached to my MBPro. I don't see it on the Retina display; if there's an issue there, it's too subtle for me to notice. But on the low-dpi screen it's very evident.

STR:

• In a new window, go to about:addons and select the Themes panel
• Search for the theme "virtualfox", and click the Install button
• Watch the text of the tab title ("Virtualfox - Get this Theme for [faded-out]") while clicking the Add button in the confirmation doorhanger
  ** Observe that when the theme is installed, the text of the tab title becomes much fuzzier. Disabling the theme restores sharp text.

Further observation: short tab titles (that aren't fade-truncated) appear fuzzy if they're inactive, but are sharp when they're the active tab. But longer titles that have the truncation effect are fuzzy regardless of their active/inactive status.

I don't see this issue on Ubuntu, using the same theme. But I do see it on Windows using a low-dpi (system scaling 100%) display. On a higher-res display, it's pretty much imperceptible.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: about;support.txt

(In reply to Glenn Watson [:gw] from comment #9)

I haven't been able to reproduce yet, it might depend on resolution / dpi / platform etc. Could you paste what your about:support contains and also a specific URL that it reproduces on for you?

Sure, please have a look.

Resolution - 1680x1050
DPI - 96
DPI Level - 100%
Platform - Windows 7

The issue is reproducible for me for example on https://addons.mozilla.org/pl/firefox/addon/virtualfox/

Comment 12

[Glenn Watson [:gw]]

This try build [1] appears to fix the issue for me. The Windows build artifacts can be found at [2] if you are able to verify it fixes the issue locally for you - otherwise, I'll try to get this landed today and it should be in a nightly tomorrow.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=b804688f94fd9d0f278276e66c35bbffd1ee3788&selectedTaskRun=YPxthhQATIOhyUB9em-Eqw.0

[2] https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bjkTLoelSu2UAXDbFdroEg/runs/0/artifacts/public/build/target.zip

Comment 13

[Glenn Watson [:gw]]

I believe this should be fixed when the patches in [1] land in a nightly. Let's wait until then to confirm and hopefully dup/close this bug.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1757032#c5

Comment 14

[Jonathan Kew [:jfkthame]]

I tested the try build (comment 12) on macOS, and can confirm it fixes the issue here.

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm also confirming that build from Comment #12 fixed the issue, same as it's fixed with latest Mozilla Firefox Nightly 99.0a1 (2022-02-25) (64-bit) [rev: c875dbd49223e460b596f01cc6564c6fb97d59c4].

https://hg.mozilla.org/mozilla-central/rev/01f4d5ac6b6b

Thank you very much for instant fix!