1757095 - Display creation date in addition to expiry date in Key Manager

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Nicolas Falquet]

Expired keys are already marked in gray and italic in the Key Manager. Display the expiration date by default on top of this is not super useful.

Instead, the creation date could be more useful to distinguish an old from a key.

Comment 1

[Magnus Melin [:mkmelin]]

Agreed that should be added.
See
https://searchfox.org/comm-central/rev/48c2cd9cce1c0438975d7f92190cb9e2cdd9ef70/mail/extensions/openpgp/content/ui/enigmailKeyManager.js#1333
https://searchfox.org/comm-central/rev/48c2cd9cce1c0438975d7f92190cb9e2cdd9ef70/mail/extensions/openpgp/content/ui/enigmailKeyManager.xhtml#261

@Snip, maybe something you'd like to work on?

Comment 2

[SnipFoo]

Hello,

Yes, I guess this is something for which I can try to submit a patch :)

However, I'm afraid displaying the creation date (even with some extra text, such as “Created on XX/XX/XXXX”) instead of the expiry date in the “Expiry” column when the key is expired might be confusing for some users. One could change the column heading, of course, but we'd still have two types of dates in the same column, which I think might be confusing as well.

Maybe one could just add a “Created” column instead, with the creation date of each key in the keyring, just between the “Key ID” and the “Expiry” columns. Would that be an acceptable solution? Or did you have something else in mind?

Thanks!

SnipFoo.

Comment 3

[Magnus Melin [:mkmelin]]

Adding a Created column is what I'd do yes!

Comment 4

[SnipFoo]

Attachment: Bug 1757095 - Add “Created” column with each key's creation date in Key Manager. r=mkmelin

Also add an extra function to the keyRing module for sorting keys according
to their creation date.

Comment 5

[SnipFoo]

Well, here goes :)
Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d10838bb567
Add “Created” column with each key's creation date in Key Manager. r=mkmelin