1757100 - Move platform-dependent parts of RWLock to mozglue

Status: RESOLVED FIXED

(Core :: mozglue, task)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I have a need for a readers-writer lock (aka shared lock) in the Base Profiler, and we already have mozilla::RWLock, but it's in xpcom.

Similar to how mozilla::Mutex in xpcom uses a light class mozilla::detail::MutexImpl in mozglue/misc/PlatformMutex.h, I would like to have a mozilla::detail::RWLockImpl in mozglue/misc/PlatformRWLock.h, which would contain the minimal platform-dependent API to implement RWLock.
(And I could use that RWLockImpl in the Base Profiler, like I already use MutexImpl.)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1757100 - Move minimal platform-dependent part of RWLock to mozglue/misc/PlatformRWLock.h&cpp - r?glandium,#xpcom-reviewers

This is consistent with how xpcom's Mutex has its platform-dependent code in mozglue, and will allow readers-writer locks in mozglue without duplication.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1757100 - Sprinkle [[nodiscard]] and =delete in RWLock.h - r?glandium,#xpcom-reviewers

Depends on D139669

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ad74e152f2e
Move minimal platform-dependent part of RWLock to mozglue/misc/PlatformRWLock.h&cpp - r=glandium,xpcom-reviewers
https://hg.mozilla.org/integration/autoland/rev/128be99c373b
Sprinkle [[nodiscard]] and =delete in RWLock.h - r=glandium,xpcom-reviewers

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6ad74e152f2e
https://hg.mozilla.org/mozilla-central/rev/128be99c373b