Closed Bug 1757106 Opened 9 months ago Closed 9 months ago

Preferences popups when zoomed are mispositioned (was: Clean-up Wayland popup positioning)

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

https://bugzilla.mozilla.org/attachment.cgi?id=9265427 is enough to fix bug 1750487 since it what caused a resize loop on wayland when zoom was applied, but the other patches also make sense and make the code both nicer and less error-prone, so let's get them landed too.

Store preferred rect in dev pixels, which simplifies a bit other calculations,
and ensures that the nsMenuPopupFrame code accounts for zoom etc.

Use existing conversion methods for GDK <-> Device <-> CSS conversions.

DevicePixelsToGdkRectRoundOut should have the same behavior here and is
simpler / less weird than having a positionless rect variable to
represent a size.

Depends on D139623

Summary: Clean-up wayland popup positioning → Preferences popups when zoomed are mispositioned (was: Clean-up Wayland popup positioning)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/420728eba6a0
Clean up menu popup rect handling. r=stransky
https://hg.mozilla.org/integration/autoland/rev/975f49d4b685
Cleanup size/pos handling in NativeMoveResize. r=stransky
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1adc73ab00de
Don't update popup hierarchy if position and size didn't change in nsWindow::NativeMoveResizeWaylandPopup. r=stransky
https://hg.mozilla.org/integration/autoland/rev/803b5bac0909
Fix early-out in nsMenuPopupFrame::MoveTo to account for margins. r=stransky
Regressions: 1758594
QA Whiteboard: [qa-99b-p2]
You need to log in before you can comment on or make changes to this bug.