1757106 - Preferences popups when zoomed are mispositioned (was: Clean-up Wayland popup positioning)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

https://bugzilla.mozilla.org/attachment.cgi?id=9265427 is enough to fix bug 1750487 since it what caused a resize loop on wayland when zoom was applied, but the other patches also make sense and make the code both nicer and less error-prone, so let's get them landed too.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757106 - Clean up menu popup rect handling. r=stransky

Store preferred rect in dev pixels, which simplifies a bit other calculations,
and ensures that the nsMenuPopupFrame code accounts for zoom etc.

Use existing conversion methods for GDK <-> Device <-> CSS conversions.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757106 - Cleanup size/pos handling in NativeMoveResize. r=stransky

DevicePixelsToGdkRectRoundOut should have the same behavior here and is
simpler / less weird than having a positionless rect variable to
represent a size.

Depends on D139623

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757106 - Don't update popup hierarchy if position and size didn't change in nsWindow::NativeMoveResizeWaylandPopup. r=stransky

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757106 - Fix early-out in nsMenuPopupFrame::MoveTo to account for margins. r=stransky

This was also broken.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/420728eba6a0
Clean up menu popup rect handling. r=stransky
https://hg.mozilla.org/integration/autoland/rev/975f49d4b685
Cleanup size/pos handling in NativeMoveResize. r=stransky

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1adc73ab00de
Don't update popup hierarchy if position and size didn't change in nsWindow::NativeMoveResizeWaylandPopup. r=stransky
https://hg.mozilla.org/integration/autoland/rev/803b5bac0909
Fix early-out in nsMenuPopupFrame::MoveTo to account for margins. r=stransky

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/420728eba6a0
https://hg.mozilla.org/mozilla-central/rev/975f49d4b685
https://hg.mozilla.org/mozilla-central/rev/1adc73ab00de
https://hg.mozilla.org/mozilla-central/rev/803b5bac0909