Open Bug 1757199 Opened 3 years ago Updated 3 years ago

Remove error-swallowing after using ExtensionData in SpecialPowersParent.jsm + test coverage

Categories

(WebExtensions :: General, task, P3)

Product:
WebExtensions
Component:
General
Type:
task

Tracking

(Not tracked)

People

(Reporter: robwu, Unassigned)

References

Details

There is some Pokemon exception handling going on at https://searchfox.org/mozilla-central/rev/a17011de808c24f015ad03debe7a157c1b43b602/testing/specialpowers/content/SpecialPowersParent.jsm#1174-1178

Originally that code was added because loadManifest could fail for embedded webextensions. But we haven't supported these for years, so to avoid silently swallowing errors, remove the unconditional exception handler.

I don't see any unit test that checks for "Extension contains packaging errors" (reported in the same code), so for better test coverage of the test utility we should probably try to load such an extension.

And we should consider passing the isPrivileged flag to the ExtensionData constructor, in case there are privileged features (depending on bug 1734987), and add tests for these.

Severity: -- → N/A
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.