1757253 - Always false comparison in StreamLoader::OnStartRequest()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Andrew McCreight [:mccr8]]

[...]/layout/style/StreamLoader.cpp:46:28: warning: result of comparison 'uint64_t' (aka 'unsigned long long') > 18446744073709551615 is always false [-Wtautological-type-limit-compare]

I noticed this warning passing by when I did a local build. This line of code was changed in bug 1741665. I think it is a regression because that bug changed nsACString::size_type from uint32_t to size_t.

The actual check is: uint64_t(length) > std::numeric_limits<nsACString::size_type>::max().

I guess this check isn't trivial on 32-bit builds...

Comment 1

[Andrew McCreight [:mccr8]]

This is just a compiler warning in 64 bit builds, so there's no user impact.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:nika, since you are the author of the regressor, bug 1741665, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1757253 - Use CheckedInt to avoid unnecessary warning in 64-bit builds, r=mccr8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42a0797b0370
Use CheckedInt to avoid unnecessary warning in 64-bit builds, r=emilio

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/42a0797b0370