1757373 - Running linters across the entire tree (with ./mach lint .) uses a single processor rather than multiple

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Mark Banner (:standard8)]

Bug 1369784 made it so that you have to enter ./mach lint -l eslint . or ./mach eslint . to run ESLint across the whole tree.

Unfortunately this means that we're now running ESLint in single-process mode rather than multiple.

Whilst you could use ./mach eslint * this isn't necessarily enough as it doesn't lint the hidden files (.eslintrc.js etc).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1369784

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:nisargkarun1997, since you are the author of the regressor, bug 1369784, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:ahal, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Andrew Halberstadt [:ahal]]

Still an issue, though unclear how to fix and doesn't feel too major.

Maybe if we detect a single directory is passed in, we can automatically expand it out to the files / subdirs contain within it. Then we'd use multiple processes. Also this isn't ESLint specific.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1757373 - Enable linting to run in parallel when '.' is specified as the path. r?#linter-reviewers!

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1757373 - Switch source task linters to use '.' rather than '*' for path matching, so that dot files are also checked. r?#linter-reviewers!

Currently dot files (e.g. .eslintrc.js) are not checked in the full run on CI.

Also ignores .gradle/ directory as that it a cache.

Depends on D177260

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=09b733e73c7bdfc3b3ba4c074133ebf92a754e55&selectedTaskRun=Uioir3vmSNK183cMRtou7Q.0

(the black & ES failures were test failures that are resolved in the patches).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06496fa5b104
Enable linting to run in parallel when '.' is specified as the path. r=linter-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/e2d7eedc3ba5
Switch source task linters to use '.' rather than '*' for path matching, so that dot files are also checked. r=linter-reviewers,sylvestre

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/06496fa5b104
https://hg.mozilla.org/mozilla-central/rev/e2d7eedc3ba5