Closed Bug 1757399 Opened 3 years ago Closed 3 years ago

Perma TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | test_temporary_experiments_enabled - [test_temporary_experiments_enabled : 83] addon.isPrivil when Gecko 99 merges to Beta on 2022-03-08

Categories

(WebExtensions :: General, defect, P1)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox-esr91 unaffected, firefox97 unaffected, firefox98 unaffected, firefox99+ verified)

Status:
VERIFIED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 + verified

People

(Reporter: noriszfay, Assigned: robwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1757399 - Correct test expectation for experiments
48 bytes, text/x-phabricator-request
Details | Review

Central-as-beta simulation
How to run these simulations

Failure log:

[task 2022-02-28T13:05:10.835Z] 13:05:10     INFO -  TEST-START | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js
[task 2022-02-28T13:05:12.078Z] 13:05:12  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | xpcshell return code: 0
[task 2022-02-28T13:05:12.078Z] 13:05:12     INFO -  TEST-INFO took 1242ms
[task 2022-02-28T13:05:12.078Z] 13:05:12     INFO -  >>>>>>>
[task 2022-02-28T13:05:12.078Z] 13:05:12     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-02-28T13:05:12.079Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-02-28T13:05:12.079Z] 13:05:12     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-02-28T13:05:12.079Z] 13:05:12     INFO -  running event loop
[task 2022-02-28T13:05:12.079Z] 13:05:12     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | Starting setup
[task 2022-02-28T13:05:12.080Z] 13:05:12     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2022-02-28T13:05:12.082Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-02-28T13:05:12.082Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511302	addons.manager	DEBUG	Application has been upgraded"
[task 2022-02-28T13:05:12.086Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511302	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]"
[task 2022-02-28T13:05:12.089Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511309	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm"
[task 2022-02-28T13:05:12.091Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511310	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2022-02-28T13:05:12.091Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511310	addons.xpi	DEBUG	startup"
[task 2022-02-28T13:05:12.092Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511311	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2022-02-28T13:05:12.092Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511311	addons.xpi	INFO	Removing all system add-on upgrades."
[task 2022-02-28T13:05:12.092Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511312	addons.xpi	DEBUG	checkForChanges"
[task 2022-02-28T13:05:12.092Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511312	addons.xpi	DEBUG	Loaded add-on state: ${}"
[task 2022-02-28T13:05:12.093Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511314	addons.xpi	DEBUG	No list of valid system add-ons found."
[task 2022-02-28T13:05:12.093Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511314	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2022-02-28T13:05:12.093Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511315	addons.xpi	DEBUG	Empty XPI database, setting schema version preference to 35"
[task 2022-02-28T13:05:12.093Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511315	addons.xpi	DEBUG	No changes found"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511319	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511320	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511320	addons.manager	DEBUG	Completed startup sequence"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511527	addons.xpi-utils	WARN	Synchronous load of XPI database due to getAddonsByType([theme]) Stack: getAddonsByType@resource://gre/modules/addons/XPIDatabase.jsm:2209:21
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  installBuiltinAddon@resource://gre/modules/addons/XPIInstall.jsm:4471:24
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:604:5
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  @-e:1:1
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511527	addons.xpi-utils	DEBUG	Synchronously loading the add-ons database"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511528	addons.xpi-utils	DEBUG	Starting async load of XPI database /tmp/xpc-profile-m1kd8w6c/extensions.json"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511529	addons.xpi-utils	DEBUG	Rebuilding XPI database with no extensions"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511530	addons.xpi-utils	DEBUG	Make addon app-builtin:default-theme@mozilla.org visible"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511530	addons.xpi	DEBUG	XPIStates adding add-on default-theme@mozilla.org in {"addons":{},"staged":{}}: null"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511531	addons.xpi	DEBUG	Updating XPIState for {"id":"default-theme@mozilla.org","syncGUID":"{2cdefb0a-5200-4ced-aa4c-edbcb562c4b3}","version":"1.3","type":"theme","loader":null,"updateURL":null,"installOrigins":null,"manifestVersion":2,"optionsURL":null,"optionsType":null,"optionsBrowserStyle":true,"aboutURL":null,"defaultLocale":{"name":"System theme — auto","description":"Follow the operating system setting for buttons, menus, and windows.","creator":"Mozilla","developers":null,"translators":null,"contributors":null},"visible":true,"active":true,"userDisabled":false,"appDisabled":false,"embedderDisabled":false,"installDate":1646053511530,"applyBackgroundUpdates":1,"path":null,"skinnable":false,"sourceURI":null,"releaseNotesURI":null,"softDisabled":false,"foreignInstall":false,"strictCompatibility":true,"locales":[],"targetApplications":[{"id":"toolkit@mozilla.org","minVersion":null,"maxVersion":null}],"targetPlatforms":[],"signedDate":null,"seen":true,"dependencies":[],"userPermissions":null,"optionalPermissions":null,"icons":{"32":"icon.svg"},"iconURL":null,"blocklistState":0,"blocklistURL":null,"startupData":null,"hidden":false,"installTelemetryInfo":null,"recommendationState":null,"rootURI":"resource://default-theme/","location":"app-builtin"}"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511541	addons.xpi	DEBUG	Loading bootstrap scope from resource://default-theme/"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511542	addons.xpi	DEBUG	Calling bootstrap method install on default-theme@mozilla.org version 1.3"
[task 2022-02-28T13:05:12.094Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511544	addons.xpi	DEBUG	Calling bootstrap method startup on default-theme@mozilla.org version 1.3"
[task 2022-02-28T13:05:12.098Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-02-28T13:05:12.098Z] 13:05:12     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2022-02-28T13:05:12.098Z] 13:05:12     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | Starting test_regular_addon
[task 2022-02-28T13:05:12.098Z] 13:05:12     INFO -  (xpcshell/head.js) | test test_regular_addon pending (2)
[task 2022-02-28T13:05:12.099Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-02-28T13:05:12.099Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511630	addons.webextension.@with-privileged-perm	WARN	Loading extension '@with-privileged-perm': Reading manifest: Invalid extension permission: mozillaAddons"
[task 2022-02-28T13:05:12.100Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511676	addons.xpi-utils	DEBUG	XPI Database saved, setting schema version preference to 35"
[task 2022-02-28T13:05:12.100Z] 13:05:12     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | test_regular_addon - [test_regular_addon : 83] addon.isPrivileged - false == false
<...>
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | test_temporary_privileged_signature - [test_temporary_privileged_signature : 94] Privileged permission should exist - {"permissions":["mozillaAddons","cookies"],"origins":[]} deepEqual {"origins":[],"permissions":["mozillaAddons","cookies"]}
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 9 pending (2)
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  (xpcshell/head.js) | test test_temporary_privileged_signature finished (2)
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | Starting test_temporary_experiments_enabled
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  (xpcshell/head.js) | test test_temporary_experiments_enabled pending (2)
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  (xpcshell/head.js) | test run_next_test 9 finished (2)
[task 2022-02-28T13:05:12.121Z] 13:05:12  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js | test_temporary_experiments_enabled - [test_temporary_experiments_enabled : 83] addon.isPrivileged - false == true
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js:null:83
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:240
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:604
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  -e:null:1
[task 2022-02-28T13:05:12.121Z] 13:05:12     INFO -  exiting test
[task 2022-02-28T13:05:12.122Z] 13:05:12     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:875:20
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:976:5
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:75:21
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  @/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_loadManifest_isPrivileged.js:83:10
[task 2022-02-28T13:05:12.123Z] 13:05:12     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2022-02-28T13:05:12.124Z] 13:05:12     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:604:5
[task 2022-02-28T13:05:12.124Z] 13:05:12     INFO -  @-e:1:1
[task 2022-02-28T13:05:12.124Z] 13:05:12     INFO -  exiting test
[task 2022-02-28T13:05:12.125Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511903	addons.webextension.@with-privileged-perm	WARN	Loading extension '@with-privileged-perm': Reading manifest: Invalid extension permission: mozillaAddons"
[task 2022-02-28T13:05:12.125Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511914	addons.xpi	DEBUG	Calling bootstrap method shutdown on default-theme@mozilla.org version 1.3"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511915	addons.manager	DEBUG	before shutdown"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511915	addons.manager	DEBUG	shutdown"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511915	addons.manager	DEBUG	Calling shutdown blocker for XPIProvider"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511915	addons.xpi	DEBUG	shutdown"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511915	addons.xpi-utils	DEBUG	shutdown"
[task 2022-02-28T13:05:12.126Z] 13:05:12     INFO -  "CONSOLE_MESSAGE: (info) 1646053511919	addons.manager	DEBUG	Async provider shutdown done"
[task 2022-02-28T13:05:12.127Z] 13:05:12     INFO -  <<<<<<<
[task 2022-02-28T13:05:12.128Z] 13:05:12     INFO -  INFO | Result summary:
[task 2022-02-28T13:05:12.128Z] 13:05:12     INFO -  INFO | Passed: 1241
[task 2022-02-28T13:05:12.129Z] 13:05:12  WARNING -  INFO | Failed: 1
Flags: needinfo?(rob)

Hey Rob,
I took a look to the failure logs and the permafailure is due to the fact that AddonSettings.EXPERIMENTS_ENABLED is true in nightly but false in beta builds, I think that we should skip test_temporary_experiments_enabled when AddonSettings.EXPERIMENTS_ENABLED is false.

Assignee: nobody → rob
Severity: -- → N/A
Status: NEW → ASSIGNED
Type: defect → task
Flags: needinfo?(rob)
Priority: -- → P1
Type: task → defect
Has Regression Range: --- → yes
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/d9150cf376ac Correct test expectation for experiments r=rpl

https://hg.mozilla.org/mozilla-central/rev/d9150cf376ac

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch

The issue is not reproducible anymore in today's beta-sim: https://treeherder.mozilla.org/jobs?repo=try&revision=6512abb038e49602da304199f39e619bec614627&group_state=expanded

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: