1757581 - Triggering view-source when the console input has focus should open page source not do nothing

Status: VERIFIED FIXED

(DevTools :: Console, defect, P3)

Description

[:glob ✱]

Steps to reproduce

1. Navigate to any web page
2. Open dev tools Console and ensure it has focus
3. Press "View Source" keyboard shortcut (eg. cmd+U on macOS)

Expected results

• Source for the current web page is opened in a tab

Actual result

• Menu item flashes
• Nothing else 🙁

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nchevobbe, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Note that this is only true when the console input has the focus. If you put the cursor in the "Filter Output" element and hit Cmd + U, it does work.
It seems that Ctrl+U is captured by CodeMirror for it undoSelection command (https://codemirror.net/doc/manual.html#commands), but
we can probably drop that and do the same thing we did than for Cmd/Ctrl+F (devtools/client/webconsole/components/Input/JSTerm.js#500-501 )

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1757581 - [devtools] Don't handle Ctrl/Cmd+U in JSTerm. r=jdescottes.

The shortcut is already used to open view-source and we want to let it through.
CodeMirror is using Ctrl+U for its undoSelection command, but it doesn't seem
like an important feature, so we can simply drop it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ced98831523c
[devtools] Don't handle Ctrl/Cmd+U in JSTerm. r=jdescottes.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ced98831523c

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this on a 2022-03-01 Nightly build(20220301215224) on macOS 11. Verified as fixed on Firefox Firefox 100.0(20220428192727) and Nightly 101.0a1(20220501190841) on macOS 11, Win10 64-bits and Ubuntu 20.04.

Comment 7

[:glob ✱]

🎉 ty!