1757588 - Make it possible to enforce aa for axis-aligned primitives

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Bug 1753986 added some plumbing to communicate that a primitive needs anti-aliasing but we end up ignoring it in the brush shader where we check whether the transform is axis-aligned.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1757588 - Add missing plumbing to force anti-aliasing of axis-aligned rectangles. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1757588 - Reorganize the primitive instance flag bits. r=gw

The goal is to allow the brush flags to use more bits in a followup changes.Currently it uses all of its available 8 bits, this patch allows it to use up to 12.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3dbc4e70fc7
Reorganize the primitive instance flag bits. r=gw
https://hg.mozilla.org/integration/autoland/rev/89ae192e5434
Add missing plumbing to force anti-aliasing of axis-aligned rectangles. r=gw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f3dbc4e70fc7
https://hg.mozilla.org/mozilla-central/rev/89ae192e5434

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/4d80f4e1809a
Backed out 2 changesets "for shader related crashes".a=backout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/004e55aa837d
Reorganize the primitive instance flag bits. r=gw

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/004e55aa837d

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1757588 - Take the FORCE_AA flag into account in the shader. r=gw

Depends on D139958

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6253846d257d
Add missing plumbing to force anti-aliasing of axis-aligned rectangles. r=gw
https://hg.mozilla.org/integration/autoland/rev/e65f44696571
Take the FORCE_AA flag into account in the shader. r=gw

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6253846d257d
https://hg.mozilla.org/mozilla-central/rev/e65f44696571