1757605 - Add mozilla::ipc::SentinelReadError to the prefix list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Andrew McCreight [:mccr8]]

In bug 1757534, we had a crash regression land in Nightly, but nobody noticed it for a little over a month. There was a steady trickle of crashes, but presumably because it only affected ARM64 Windows 10, there was not enough volume to catch anybody's attention. Probably part of the issue is that this is a rather generic signature, combining a number of IPC serialization issues. Maybe regressions in these sorts of crashes would be more noticeable if we add mozilla::ipc::SentinelReadError to the prefix list.

Here's an example of these crashes: bp-32f63301-804f-4e9d-ba52-bfb670220301

With this addition to the prefix list, I think the signature would go from [@ mozilla::ipc::SentinelReadError] to [@mozilla::ipc::SentinelReadError | mozilla::ipc::SentinelReadError | mozilla::gmp::PGMPParent::OnMessageReceived]. The double SentinelReadError isn't great, but I think it is nice to have an indication that this is specifically a deserialization error, and not some other kind of unknown crash.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6025: bug 1757605: add mozilla::ipc::SentinelReadError to prefix list

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6025: "bug 1757605: add mozilla::ipc::SentinelReadError to prefix list" in 824eaab.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks!

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod just now in bug #1759160. Marking as FIXED.