Regenerate ExtensionTest.webidl to use new methods signature on optional parameters introduced in Bug 1748714
Categories
(WebExtensions :: General, task, P2)
Tracking
(firefox100 fixed)
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
As a follow up to Bug 1748714 ExtensionTest.webidl should also be regenerated using the GenerateWebIDLBindings python script (as updated in Bug 1748714 to match the preferred ones from a WebIDL peer perspective).
ExtensionTest is one of the few APIs that includes methods that are expecting some call parameters that can't be structured cloned and sent as is from the worker thread (where the call is originated) to the main thread (where the API call handler is executed).
And so some of the changes to the ExtensionTest.webidl methods type signature requires some small tweaks to the related implementated methods in ExtensionTest.h and ExtensionTest.cpp.
(Unlike ExtensionAlarm.webidl and ExtensionRuntime.webidl which have been already updated in Bug 1748714, both of them didn't require any change besides regenerating the webidl files because the new methods type signatures are all handled by the CallWebExtMethod*
stub methods without requiring any additional change to the cpp implementation).
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D136952
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/acaa10b52cec Regenerated ExtensionTest API webidl definitions and update implementation accordingly. r=mixedpuppy,peterv
Comment 3•2 years ago
|
||
bugherder |
Description
•