Closed Bug 1757736 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33028 - Change test utility name and replace comments

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33028 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33028
Details from upstream follow.

Seokho Song <seokho@chromium.org> wrote:

Change test utility name and replace comments

According to the comment [1] the test utility function 'compareValueCloseTo' tests only 'transform' property but receive the target property as a parameter,
it should be renamed to 'test_transform_values_close_to' and remove the target property .

And remove comments that are not needed.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2774851/comments/388c2b14_09e11d5b

Change-Id: Idccd640811d93da89edbc5ad5738527344b04902
Reviewed-on: https://chromium-review.googlesource.com/3473785
WPT-Export-Revision: 6da4772071af1fa5a5194afec15fe3eb33d45cf9

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8a40b23a97b [wpt PR 33028] - Change test utility name and replace comments, a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca7a0e35f484 [wpt PR 33028] - Change test utility name and replace comments, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.