Closed Bug 1757751 Opened 9 months ago Closed 7 months ago

Invert Win32 nsWindow::mAspectRatio to make it mean what it says

Categories

(Core :: Widget: Win32, defect, P2)

All
Windows
defect

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: cmartin, Assigned: the.other.feller)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The universally-accepted definition of "aspect ratio" is width/height. I don't know why the Win32 Widget code defines it to be the inverse of that, but it's in direct violation of the way we use the term "aspect ratio" everywhere else in our code, as well as the way the same code in Linux does it. Luckily it's not used yet in too many places, but let's invert this before things get even more out of hand.

Keywords: good-first-bug
Assignee: cmartin → nobody
Status: ASSIGNED → NEW

Hey, I am working on it! Would be nice, if I could be assigned :)

Assignee: nobody → the.other.feller
Attachment #9273913 - Attachment description: WIP: Bug 1757751 - Invert Win32 nsWindow::mAspectRatio so it follows the standard definition. → Bug 1757751 - Invert Win32 nsWindow::mAspectRatio so it follows the standard definition.
Status: NEW → ASSIGNED
Pushed by cmartin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f1677401ed
Invert Win32 nsWindow::mAspectRatio so it follows the standard definition. r=cmartin
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.