1757753 - 0.16 - 0.13% installer size / installer size + 2 more (OSX) regression on Mon February 28 2022

Status: RESOLVED WONTFIX

(Core :: IPC, defect)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push 1d9f17244335bc42a2d627d45bb3b059bf0b18c6. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.16%	installer size	osx-shippable	nightly	83,161,295.32 -> 83,291,255.58
0.15%	installer size	osx-aarch64-shippable	aarch64 nightly	80,729,871.64 -> 80,848,249.83
0.13%	installer size	osx-cross		80,245,280.25 -> 80,348,761.42
0.13%	installer size	osx-shippable	instrumented	117,515,701.08 -> 117,667,847.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1751948

Comment 2

[Nika Layzell [:nika] (ni? for response)]

It makes sense that the unified build changes in that bug could lead to changes in installer size, as we now unify a large number of files differently than we did before.

ni? :glandium to see if we care about this magnitude of change.

Comment 3

[Mike Hommey [:glandium]]

It's worth noting that unless I'm wrong, this doesn't seem to have been accompanied by a corresponding regression in XUL size. This suggests somehow the generated code is less compressible. I'd say it's ok to WONTFIX this.