1757754 - Perma Windows MinGW all [tier 2] /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp:265:10: error: use of undeclared identifier 'ERROR_CONTENT_BLOCKED'

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=369680555&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YOvMhI9NRIeG6UEdDvTRvw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-03-02T14:24:23.969Z] 14:24:23     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/io'
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -std=gnu++17 -o nsLocalFileWin.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/xpcom/io -I/builds/worker/workspace/obj-build/xpcom/io -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/xpcom -I/builds/worker/checkouts/gecko/xpcom/build -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -Wno-incompatible-ms-struct -mstackrealign -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -fno-strict-aliasing  -MD -MP -MF .deps/nsLocalFileWin.o.pp   /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp
[task 2022-03-02T14:24:23.973Z] 14:24:23    ERROR -  /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp:265:10: error: use of undeclared identifier 'ERROR_CONTENT_BLOCKED'
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -      case ERROR_CONTENT_BLOCKED:
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -           ^
[task 2022-03-02T14:24:23.973Z] 14:24:23  WARNING -  /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp:1658:20: warning: passing object of class type 'typename raw_type<char16_t, int>::type' (aka 'char16ptr_t') through variadic function [-Wclass-varargs]
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -                     NS_ConvertASCIItoUTF16(nsDependentCString(aField)).get());
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -                     ^
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -  1 warning and 1 error generated.
[task 2022-03-02T14:24:23.973Z] 14:24:23    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: nsLocalFileWin.o] Error 1
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/xpcom/io'
[task 2022-03-02T14:24:23.973Z] 14:24:23    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: xpcom/io/target-objects] Error 2
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-03-02T14:24:23.973Z] 14:24:23     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/reflect/xptinfo'

Comment 1

[Iulian Moraru]

Hi Jan! Can you please take a look at this? This is caused by your recent changes in Bug 1690326.
Thank you!

Comment 2

[Jan Rio Krause]

Iulian, thank you for letting me know. I'm already on it.

Comment 3

[Tom Ritter [:tjr]]

This constant is in mingw: https://searchfox.org/mingw-moz/search?q=ERROR_CONTENT_BLOCKED&path=&case=false&regexp=false

Maybe the header is not included? You can do try builds for the mingw compilation to test.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 5

[Jens Stutte [:jstutte]]

(In reply to Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc) from comment #3)

This constant is in mingw: https://searchfox.org/mingw-moz/search?q=ERROR_CONTENT_BLOCKED&path=&case=false&regexp=false

Maybe the header is not included? You can do try builds for the mingw compilation to test.

So if searchfox is not lying, those headers are not in-tree (there is only something for rust and for the crashreporter ) for none of our build variants (which makes sense as they are part of the OS environment). That would probably mean that the build-win32-mingwclang task definition in treeherder contains an old snapshot of MinGW, but I (and Jan) do not know how to update or even check this.

Comment 6

[Tom Ritter [:tjr]]

https://searchfox.org/mingw-moz/source/ is the version of mingw used in mozilla-central; https://searchfox.org/mingw/source/ is upstream - so it is in our version. I meant that perhaps the winerror.h header is not included where you use this constant; but it is included by default in the clang-cl builds and not mingw.

Comment 7

[Jens Stutte [:jstutte]]

(In reply to Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc) from comment #6)

https://searchfox.org/mingw-moz/ is the version of mingw used in mozilla-central;

The first link is giving me a 404? I can see the taskcluster scripts in searchfox but I am totally lost here.

Comment 8

[Masatoshi Kimura [:emk]]

While mingw-w64-tools/widl/include/winerror.h contains ERROR_CONTENT_BLOCKED, mingw-w64-headers/include/winerror.h does not. What's the difference of them?

(In reply to Jens Stutte [:jstutte] from comment #7)

The first link is giving me a 404?

Searchfox should not give 404 for the top page...
https://searchfox.org/mingw-moz/source/

Comment 9

[Tom Ritter [:tjr]]

Sorry; I was trying to link to the searchfox root, but it requires /source/ at the end; I updated the link.

Searchfox indexes mingw-w64 (and llvm, and rust, and some other non-mozilla repositories) for convenience. /mingw-moz/ is the source code for the specific mingw commit we use in m-c; while /mingw/ is upstream's tip.

Because ERROR_CONTENT_BLOCKED is present in the version of MinGW used in mozilla-central, my first guess is that xpcom/io/nsLocalFileWin.cpp needs an #include<winerror.h>

But now I see that winerror is included in WinHeaderOnlyUtils.h which is included in nsLocalFileWin so it seems like that is not the problem...

Comment 10

[Tom Ritter [:tjr]]

(In reply to Masatoshi Kimura [:emk] from comment #8)

While mingw-w64-tools/widl/include/winerror.h contains ERROR_CONTENT_BLOCKED, mingw-w64-headers/include/winerror.h does not. What's the difference of them?

Ah; thanks for pointing that out. Yeah; that needs to get fixed. The workaround here is an #ifdef __MINGW32__ that defines ERROR_CONTENT_BLOCKED; and a bug similar to Bug 1664365 blocking Bug 1465790 to remove the workaround.

Comment 11

[Jens Stutte [:jstutte]]

Well, that sounds similar to what we did the first time we hit this (without thinking too much) in bug 1709887. We can just add another #ifdef here and file the additional bug to remove both.

Comment 12

[Intermittent Failures Robot]

18 failures in 618 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 14
• mozilla-central: 4

Platform and build breakdown:

• windows-mingw32: 18
  • all: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1757754&startday=2022-03-02&endday=2022-03-02&tree=all

Comment 13

[Jan Rio Krause]

Attachment: Bug 1757754 - Fix MinGW build failure by defining `ERROR_CONTENT_BLOCKED`. r=#xpcom-reviewers,#dom-storage-reviewers,jstutte

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8731b76279d4
Fix MinGW build failure by defining `ERROR_CONTENT_BLOCKED`. r=xpcom-reviewers,nika

Comment 15

[Intermittent Failures Robot]

31 failures in 717 pushes (0.043 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• mozilla-central: 12

Platform and build breakdown:

• windows-mingw32: 31
  • all: 31

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1757754&startday=2022-03-03&endday=2022-03-03&tree=all

Comment 16

[Jens Stutte [:jstutte]]

(In reply to Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc) from comment #10)

and a bug similar to Bug 1664365 blocking Bug 1465790 to remove the workaround.

Hi Jan-Rio, I just landed the patch to repair the broken builds asap. Please file the removal bug (for both defines we added so far) as asked for by Tom, thanks.

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8731b76279d4

Comment 18

[Intermittent Failures Robot]

18 failures in 626 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 6
• mozilla-central: 12

Platform and build breakdown:

• windows-mingw32: 18
  • all: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1757754&startday=2022-03-04&endday=2022-03-04&tree=all

Comment 19

[Intermittent Failures Robot]

67 failures in 3063 pushes (0.022 failures/push) were associated with this bug in the last 7 days.

This is the #9 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 39
• mozilla-central: 28

Platform and build breakdown:

• windows-mingw32: 67
  • all: 67

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1757754&startday=2022-02-28&endday=2022-03-06&tree=all

Comment 20

[Jan Rio Krause]

Jens, thanks for landing the patch. I just filed Bug 1758681 to keep track of the MinGW version and the temporary workarounds.