Clean up code to download PDFs, dead after the download panel improvements work
Categories
(Firefox :: PDF Viewer, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: marco, Assigned: enndeakin)
References
Details
(Whiteboard: [fidefe-2022-downloads-followup])
Attachments
(3 files)
Given the download panel improvements work now became default in release, we can drop the code that was run when the panel improvement pref was false.
https://phabricator.services.mozilla.com/D138607 is doing this cleanup, but there is a test that is failing (see bug 1752149 comment 30).
:Gijs, why are we still running tests with the pref disabled?
Reporter | ||
Comment 1•2 years ago
|
||
Needinfo for the question in comment 0.
Comment 2•2 years ago
•
|
||
(In reply to Marco Castelluccio [:marco] from comment #0)
:Gijs, why are we still running tests with the pref disabled?
Because we didn't ship yet? We shipped today/tomorrow with 98... (and we backed out of shipping for 97 in RC week 4 weeks ago, so I'm not sorry that we kept both configurations running...)
Anyway, the test failure might be the same as bug 1751061? Is that possible?
Reporter | ||
Comment 3•2 years ago
|
||
(In reply to :Gijs (he/him) from comment #2)
(In reply to Marco Castelluccio [:marco] from comment #0)
:Gijs, why are we still running tests with the pref disabled?
Because we didn't ship yet? We shipped today/tomorrow with 98... (and we backed out of shipping for 97 in RC week 4 weeks ago, so I'm not sorry that we kept both configurations running...)
Makes sense to keep them running in the old configuration too, though what I wanted to ask was actually "why are we still running tests with the pref disabled and not with the pref enabled?". It seems this test is only running with the pref disabled and not with the pref enabled. Is the behavior the test is testing covered by other tests? Did the behavior change and so the test is no longer applicable with the pref enabled?
Anyway, the test failure might be the same as bug 1751061? Is that possible?
I haven't investigated the failure from the cleanup, it could be the same.
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b9d36ca37894 always launch the save dialog when pressing the PDF Viewer download button, and remove test code that expected the unknown type dialog to appear, r=marco
Comment 7•2 years ago
|
||
bugherder |
Comment 8•2 years ago
|
||
Comment 9•2 years ago
|
||
Commit merged into master by GitHub Authored by Tim van der Meij (timvandermeij)
Description
•