Closed Bug 1757771 Opened 2 years ago Closed 2 years ago

Clean up code to download PDFs, dead after the download panel improvements work

Categories

(Firefox :: PDF Viewer, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: marco, Assigned: enndeakin)

References

Details

(Whiteboard: [fidefe-2022-downloads-followup])

Attachments

(3 files)

Given the download panel improvements work now became default in release, we can drop the code that was run when the panel improvement pref was false.

https://phabricator.services.mozilla.com/D138607 is doing this cleanup, but there is a test that is failing (see bug 1752149 comment 30).

:Gijs, why are we still running tests with the pref disabled?

Needinfo for the question in comment 0.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Marco Castelluccio [:marco] from comment #0)

:Gijs, why are we still running tests with the pref disabled?

Because we didn't ship yet? We shipped today/tomorrow with 98... (and we backed out of shipping for 97 in RC week 4 weeks ago, so I'm not sorry that we kept both configurations running...)

Anyway, the test failure might be the same as bug 1751061? Is that possible?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mcastelluccio)
See Also: → 1751061

(In reply to :Gijs (he/him) from comment #2)

(In reply to Marco Castelluccio [:marco] from comment #0)

:Gijs, why are we still running tests with the pref disabled?

Because we didn't ship yet? We shipped today/tomorrow with 98... (and we backed out of shipping for 97 in RC week 4 weeks ago, so I'm not sorry that we kept both configurations running...)

Makes sense to keep them running in the old configuration too, though what I wanted to ask was actually "why are we still running tests with the pref disabled and not with the pref enabled?". It seems this test is only running with the pref disabled and not with the pref enabled. Is the behavior the test is testing covered by other tests? Did the behavior change and so the test is no longer applicable with the pref enabled?

Anyway, the test failure might be the same as bug 1751061? Is that possible?

I haven't investigated the failure from the cleanup, it could be the same.

Flags: needinfo?(mcastelluccio)
Whiteboard: [fidefe-2022-downloads-followup]
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9d36ca37894
always launch the save dialog when pressing the PDF Viewer download button, and remove test code that expected the unknown type dialog to appear, r=marco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Commit merged into master by GitHub
Authored by Tim van der Meij (timvandermeij)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: