1757772 - Support PiP on videos that are loaded within an iframe (e.g., https://www.nfl.com/videos/)

Status: NEW

(Toolkit :: Picture-in-Picture, enhancement, P5)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user reaches the , he will notice that...

Affected versions

• Nightly v89.0a1
• ESR v91.6.0esr

Affected platforms

• Mac OS 11
• Ubuntu 20
• Windows 10

Steps to reproduce

1. Launch browser.
2. Load https://www.nfl.com/videos/
3. Hover over the playing video.

Expected result

• PiP button appears and works.

Actual result

• The PiP button/toggle is not being displayed in these videos.

Regression range

• Not a recent regression, appears as it never worked.

Additional notes

• I suppose this could be set as invalid, but I decided to log it since this streaming service is pretty popular in the US.

Comment 1

[Ania]

Can you please update the Expected result to: Pip button is not displayed?

Why would we consider it invalid?

Comment 2

[kpatenio]

Took a quick look at the DOM for this site, and it seems videos are loaded within an iframe. PiP tries to search for video elements on a web page to insert the PiP toggle. However, the videos are not loaded as <video> elements here, so the PiP toggle is never displayed.

Comment 3

[Daniel Bodea [:danibodea]]

(In reply to amininkova from comment #1)

Can you please update the Expected result to: Pip button is not displayed?

Why would we consider it invalid?

In case it won't be supported anytime soon; felt like a possible way forward. In any case, it's good that we know it's (temporary) expected to not support the PiP.

Comment 4

[Daniel Bodea [:danibodea]]

(In reply to amininkova from comment #1)

Can you please update the Expected result to: Pip button is not displayed?

Why would we consider it invalid?

It appears I've only answered the first question in comment 2.
Answer for first: The PiP button/toggle does not appear at all and I'd expect it to appear and work on these videos.
P.S. The actual result has been corrected, also.