Closed Bug 1757956 Opened 9 months ago Closed 9 months ago

Consider renaming JSFreeOp to JS::GCContext

Categories

(Core :: JavaScript: GC, task, P5)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(5 files, 1 obsolete file)

This is now used for GC related context as well as an interface for freeing memory. It is present on any thread running GC (i.e. main thread plus helper threads running GC tasks).

We should consider renaming to reflect its new broader use.

This is a follow on from bug 1643586.

Assignee: nobody → jcoppeard

There's only one GCContext per thread so there's no concept of a 'default' context.

Depends on D140526

Attachment #9266851 - Attachment description: Bug 1757956 - Part 5: Rename defaultFreeOp() to gcContext() r?jandem → Bug 1757956 - Part 4: Rename defaultFreeOp() to gcContext() r?jandem
Attachment #9266852 - Attachment description: Bug 1757956 - Part 6: Call gcContext() method on JSContext rather than going via the runtime r?jandem → Bug 1757956 - Part 5: Call gcContext() method on JSContext rather than going via the runtime r?jandem
Depends on: 1643586
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a734e2e81d87
Part 1: Removed unused JS_freeop API r=jandem
https://hg.mozilla.org/integration/autoland/rev/e8b0602ee8e0
Part 2: Rename JSFreeOp header files in preparation for the rename to GCContext r=jandem
https://hg.mozilla.org/integration/autoland/rev/12bdca633af5
Part 3: Rename JSFreeOp to JS::GCContext in the JS engine r=jandem
https://hg.mozilla.org/integration/autoland/rev/3df67fe8d54a
Part 4: Rename defaultFreeOp() to gcContext() r=jandem
https://hg.mozilla.org/integration/autoland/rev/080920a14c4a
Part 5: Call gcContext() method on JSContext rather than going via the runtime r=jandem
Attachment #9266850 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.