1757956 - Consider renaming JSFreeOp to JS::GCContext

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P5)

Description

[Jon Coppeard (:jonco)]

This is now used for GC related context as well as an interface for freeing memory. It is present on any thread running GC (i.e. main thread plus helper threads running GC tasks).

We should consider renaming to reflect its new broader use.

Comment 1

[Jon Coppeard (:jonco)]

This is a follow on from bug 1643586.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 1: Removed unused JS_freeop API r?jandem

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 2: Rename JSFreeOp header files in preparation for the rename to GCContext r?jandem

Depends on D140523

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 3: Rename JSFreeOp to JS::GCContext in the JS engine r?jandem

Depends on D140524

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 4: Rename JSFreeOp to JS::GCContext in the browser r?mccr8

Depends on D140525

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 4: Rename defaultFreeOp() to gcContext() r?jandem

There's only one GCContext per thread so there's no concept of a 'default' context.

Depends on D140526

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1757956 - Part 5: Call gcContext() method on JSContext rather than going via the runtime r?jandem

Depends on D140527

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a734e2e81d87
Part 1: Removed unused JS_freeop API r=jandem
https://hg.mozilla.org/integration/autoland/rev/e8b0602ee8e0
Part 2: Rename JSFreeOp header files in preparation for the rename to GCContext r=jandem
https://hg.mozilla.org/integration/autoland/rev/12bdca633af5
Part 3: Rename JSFreeOp to JS::GCContext in the JS engine r=jandem
https://hg.mozilla.org/integration/autoland/rev/3df67fe8d54a
Part 4: Rename defaultFreeOp() to gcContext() r=jandem
https://hg.mozilla.org/integration/autoland/rev/080920a14c4a
Part 5: Call gcContext() method on JSContext rather than going via the runtime r=jandem

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a734e2e81d87
https://hg.mozilla.org/mozilla-central/rev/e8b0602ee8e0
https://hg.mozilla.org/mozilla-central/rev/12bdca633af5
https://hg.mozilla.org/mozilla-central/rev/3df67fe8d54a
https://hg.mozilla.org/mozilla-central/rev/080920a14c4a