1757996 - Bug 312891 broke RTL context menus on Wayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Hilarious :)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 312891

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757996 - Improve context menu handling on Wayland. r=stransky

What caused the issue was that nsMenuPopupFrame::MoveTo didn't account
for the change in bug 312891. But our context menu / popup positioning
code can be much simpler if we account for the context menu offset
before-hand as an extra horizontal / vertical margin in all directions.

Then we don't need to special-case it at all.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86a8141f5590
Improve context menu handling on Wayland. r=stransky

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 86a8141f5590 (Bug 1757996) for causing failures in test_popup_attribute.xhtml CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=RylJ1no1QLmCmHPYmDeQBQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=86a8141f55908f7b22c0df53e4403c383115d986

Log: https://treeherder.mozilla.org/logviewer?job_id=369926755&repo=autoland&lineNumber=4441

Backout: https://hg.mozilla.org/integration/autoland/rev/ee3f50a230f481ed1578ec0ef5c8d717606c8074

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df7824bd0725
Improve context menu handling on Wayland. r=stransky

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/df7824bd0725