Closed Bug 1757996 Opened 7 months ago Closed 7 months ago

Bug 312891 broke RTL context menus on Wayland

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Hilarious :)

Flags: needinfo?(emilio)

Set release status flags based on info from the regressing bug 312891

What caused the issue was that nsMenuPopupFrame::MoveTo didn't account
for the change in bug 312891. But our context menu / popup positioning
code can be much simpler if we account for the context menu offset
before-hand as an extra horizontal / vertical margin in all directions.

Then we don't need to special-case it at all.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86a8141f5590
Improve context menu handling on Wayland. r=stransky
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df7824bd0725
Improve context menu handling on Wayland. r=stransky
Has Regression Range: --- → yes
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.