1758009 - Description is not proxied in RemoteAccessibleWrap

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Eitan Isaacson [:eeejay]]

We were able to get away with this until now because the description was pushed into the java cache so it was never queried directly.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1758009 - Add a forwarder for description in RemoteAccessibleWrap. r?morgan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f96452dbcfd
Add a forwarder for description in RemoteAccessibleWrap. r=morgan

Comment 3

[Iulian Moraru]

Backed out for causing android build bustages on RemoteAccessibleWrap.
Affected platforms so far: Android 5.0 x86-64 opt, Android 5.0 x86-64 debug, Android 5.0 x86-64 debug-isolated-process.

Push with failures

Failure log

Backout link

[task 2022-03-04T19:58:53.577Z] 19:58:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/android'
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 --target=x86_64-linux-android --rtlib=libgcc -o RemoteAccessibleWrap.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -ftrivial-auto-var-init=pattern -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/accessible/android -I/builds/worker/workspace/obj-build/accessible/android -I/builds/worker/checkouts/gecko/accessible/base -I/builds/worker/checkouts/gecko/accessible/generic -I/builds/worker/checkouts/gecko/accessible/html -I/builds/worker/checkouts/gecko/accessible/ipc -I/builds/worker/checkouts/gecko/accessible/ipc/other -I/builds/worker/checkouts/gecko/accessible/xpcom -I/builds/worker/checkouts/gecko/accessible/xul -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/widget/android -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include --gcc-toolchain=/builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=21 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Oz -mno-outline -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing  -MD -MP -MF .deps/RemoteAccessibleWrap.o.pp   /builds/worker/checkouts/gecko/accessible/android/RemoteAccessibleWrap.cpp
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  In file included from /builds/worker/checkouts/gecko/accessible/android/RemoteAccessibleWrap.cpp:6:
[task 2022-03-04T19:58:53.580Z] 19:58:53    ERROR -  /builds/worker/checkouts/gecko/accessible/android/RemoteAccessibleWrap.h:40:16: error: 'Description' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -    virtual void Description(nsString& aDescription) const;
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -                 ^
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/a11y/LocalAccessible.h:138:16: note: overridden virtual function is here
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -    virtual void Description(nsString& aDescription) const override;
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -                 ^
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  1 error generated.
[task 2022-03-04T19:58:53.580Z] 19:58:53    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: RemoteAccessibleWrap.o] Error 1
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/android'
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  dom/bindings/UnifiedBindings1.o
[task 2022-03-04T19:58:53.580Z] 19:58:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'

Comment 4

[Eitan Isaacson [:eeejay]]

Oops. will fix and reland.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74afbd4cbd73
Add a forwarder for description in RemoteAccessibleWrap. r=morgan

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/74afbd4cbd73