1758088 - Make atomization code assume non-null cx->zone

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

We almost have this invariant, except for JS_AtomizeAndPinString{N} calls in the browser, but we can special-case that one. This lets us speed-up the atomization code a bit.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1758088 part 1 - Remove unused XPCJSRuntime::mStrJSVals array. r?arai!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1758088 part 2 - Remove unused js::Atomize overload. r?arai!

Depends on D140303

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1758088 part 3 - Add and use js::AtomizeWithoutActiveZone. r?arai!

This code path is used to create XPConnect's pinned atoms.

Depends on D140304

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1758088 part 4 - Assume non-null zone and main thread context in atomize functions. r?arai!

Depends on D140305

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b4e514565cb
part 1 - Remove unused XPCJSRuntime::mStrJSVals array. r=arai
https://hg.mozilla.org/integration/autoland/rev/edca55f40d6c
part 2 - Remove unused js::Atomize overload. r=arai
https://hg.mozilla.org/integration/autoland/rev/22c0a321c743
part 3 - Add and use js::AtomizeWithoutActiveZone. r=arai
https://hg.mozilla.org/integration/autoland/rev/921feefb3594
part 4 - Assume non-null zone and main thread context in atomize functions. r=arai

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1b4e514565cb
https://hg.mozilla.org/mozilla-central/rev/edca55f40d6c
https://hg.mozilla.org/mozilla-central/rev/22c0a321c743
https://hg.mozilla.org/mozilla-central/rev/921feefb3594