1758239 - `personality-provider` and `activity-stream.discovery_stream.json` are created in Root Directory

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect, P3)

Description

[6k64x4ma]

Steps to reproduce:

1. Launch Firefox with a new profile.
2. Wait until personality-provider and activity-stream.discovery_stream.json are created.

Actual results:
They are created in Local Directory until https://archive.mozilla.org/pub/firefox/nightly/2022/01/2022-01-31-21-28-43-mozilla-central/
They are created in Root Directory since https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-01-09-39-42-mozilla-central/

Expected results:
I think they should be created in Local Directory.
Maybe this is regressed by Bug 1746667?

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1758239 - Map PathUtils.getLocalProfileDir() to the correct method r?gijs

This was not caught in tests because in a test both ProfD and ProfLD will map
to the same directory (e.g., on Windows they both map to
C:\Users\<username>\AppData\Local\Temp\<random>.mozrunner).

Comment 2

[Beth Rennie [:beth] (she/her)]

We only have two consumers of PathUtils.getLocalProfileDir : PersistentCache.jsm [1, 2] and PersonalityProviderWorkerClass.jsm [3]. I checked with :thecount and this will only result in us a) re-creating the discovery stream cache and b) re-running the personality provider worker, so I don't think this warrants an uplift.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d927e9e9329
Map PathUtils.getLocalProfileDir() to the correct method r=Gijs

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9d927e9e9329

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746667