175828 - PS should only be initialized once

Status: VERIFIED INVALID

(Core :: Printing: Output, defect)

Description

[rods (gone)]

The PrintSettings should only be initialized one time for each printer name.
This means once the PS has been intialized from Prefs and from the Printer it
shouldn't be re-initialized again for the printer.

If the printer name in the PS changes then if should be once again initialized
from both Prefs and from the Printer.

Comment 1

[rods (gone)]

This is important because at the moment PrintPreview isn't working correctly.
This is a regression fro a check in to the Page Setup Dialog a while back.

Comment 2

[rods (gone)]

Attachment: patch V1

This patch has the PrintSettings cache the name of the printer it was
initialized with. That way it only initializes once for the printer. If the
name changes then it will get re-initialized from the new printer.

Comment 3

[rods (gone)]

Attachment: patch v2

same as above just a minor change

Comment 4

[rods (gone)]

Attachment: patch v3

Better patch.
This patch adds two bools to the PrintSettings and then when the PS gets
initialized from Prefs or from the Printer they get set. They get unset when
the printer name changes.

This is all necessary because the Page Setup Dialog calls
initPrintSettingsFromPrinter each time it is shown. So if you have set values
they will get "written" over the next time the dialog is shown.

Comment 5

[rods (gone)]

This patch has been incorporated into Bug 167894

Comment 6

[sujay]

verified.