1758450 - Split FillArgumentArrayForExit into separate JIT/Interp cases

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

FillArgumentArrayForExit has grown organically (think "fungus") for quite a long time and is now quite tangled because it behaves fairly differently for InterpExit and JitExit. It is better to split it into two functions to clarify how things work for these use cases; we pay a little to keep the dispatch logic in sync across the two functions but gain a lot of clarity in register use, brevity, and symmetry among cases within each function.

Also, add sundry comments that clarify what's going on.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1758450 - Fork FillArgumentArrayForExit. r?rhunt

Simplify this function by splitting it into two different functions;
add various comments for clarification.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/226722322ce3
Fork FillArgumentArrayForExit. r=rhunt

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/226722322ce3