1758482 - Update dav1d to new version 28a9c46e1c36540d3276299f2e284ece1d2386be from 2022-02-04T23:02:17.000-03:00

Status: RESOLVED DUPLICATE of bug 1762954

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 39 commits:

---

5fb9f3a4601e170dc082dc5b30966d02535f9fe9 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/5fb9f3a4601e170dc082dc5b30966d02535f9fe9
Authored: 2022-03-07 12:09:44 -0500
Committed: 2022-03-07 20:23:29 +0000

CI: add threaded tests to avx512icl instance

Files Added:

• .gitlab-ci.yml
• .gitlab-ci.yml

---

b4d70152fd590a1f31b7b8a8464ebad9b6204561 by Victorien Le Couviour--Tuffet

https://code.videolan.org/videolan/dav1d-/commit/b4d70152fd590a1f31b7b8a8464ebad9b6204561
Authored: 2022-03-07 12:19:57 +0100
Committed: 2022-03-07 19:27:08 +0000

Fix delayed_fg.scaling alignment for AVX-512

Files Added:

• src/internal.h
• src/lib.c
• src/internal.h
• src/lib.c

---

65e2b5f805de71072cd80f3fed20fb6881a84d29 by James Almer

https://code.videolan.org/videolan/dav1d-/commit/65e2b5f805de71072cd80f3fed20fb6881a84d29
Authored: 2022-03-07 10:19:52 -0300
Committed: 2022-03-07 15:07:40 +0000

lib: always set operating_point_idc and max_spatial_id

This clears stale values from the context in the scenario where you first parse
a svc sequence, and then a sequence header with the reduced still picture
header flag being true immediately after it.

Files Added:

• src/obu.c
• src/obu.c

---

e3f4c70006b32d79a3d9164f2ecc90a5377a2557 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/e3f4c70006b32d79a3d9164f2ecc90a5377a2557
Authored: 2022-03-07 07:50:54 -0500
Committed: 2022-03-07 14:38:27 +0000

lib.c: clear cf after seeking

Fixes #390.

Files Added:

• src/lib.c
• src/lib.c

---

07ab20b5a2598a83fca98c52496648510df79c6d by James Almer

https://code.videolan.org/videolan/dav1d-/commit/07ab20b5a2598a83fca98c52496648510df79c6d
Authored: 2022-03-07 09:59:37 -0300
Committed: 2022-03-07 09:59:37 -0300

lib: add parenthesis for improved readability

Files Added:

• src/lib.c
• src/lib.c

---

56fc43ae2b25dd02faa04fee3b21c2c7849d40ad by James Almer

https://code.videolan.org/videolan/dav1d-/commit/56fc43ae2b25dd02faa04fee3b21c2c7849d40ad
Authored: 2022-03-06 23:34:54 -0300
Committed: 2022-03-06 23:43:21 -0300

lib: don't buffer an extra frame when there's a single spatial layer

Files Added:

• src/internal.h
• src/lib.c
• src/obu.c
• src/internal.h
• src/lib.c
• src/obu.c

---

4124eded3b316f457ce8616fecd6f5c1734952b3 by James Almer

https://code.videolan.org/videolan/dav1d-/commit/4124eded3b316f457ce8616fecd6f5c1734952b3
Authored: 2022-03-04 17:57:28 -0300
Committed: 2022-03-04 17:57:28 -0300

lib: clear cached_error on flush

Files Added:

• src/lib.c
• src/lib.c

---

3262e3d0c89c83389e5bec32d7d81564077e2687 by Wan-Teh Chang

https://code.videolan.org/videolan/dav1d-/commit/3262e3d0c89c83389e5bec32d7d81564077e2687
Authored: 2022-03-04 00:38:20 +0000
Committed: 2022-03-04 00:38:20 +0000

dav1d_flush should set frame threads' retval to 0

Files Added:

• src/lib.c
• src/lib.c

---

b53ff29d80a21180e5ad9bbe39a02541151f4f53 by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/b53ff29d80a21180e5ad9bbe39a02541151f4f53
Authored: 2022-03-02 00:24:08 +0200
Committed: 2022-03-02 00:25:09 +0200

arm: itx: Do clipping in all narrowing downshifts

This should avoid the risk of unexpected wraparound. This shouldn't
technically be needed for spec compliant bitstreams. In practice,
this fixes the mismatch observed in issue !388 (in checkasm generated
input data).

Files Added:

• src/arm/32/itx.S
• src/arm/64/itx.S
• src/arm/32/itx.S
• src/arm/64/itx.S

---

0028e8ea57b9391915e97c8f69251bf47dd13357 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/0028e8ea57b9391915e97c8f69251bf47dd13357
Authored: 2022-02-17 23:21:18 +0100
Committed: 2022-02-28 19:23:36 +0100

x86: Add 8-bit film grain AVX-512 (Ice Lake) asm

Files Added:

• src/x86/filmgrain_avx512.asm
• src/x86/filmgrain_common.asm
• src/x86/filmgrain_avx512.asm
• src/x86/filmgrain_common.asm

Files Added:

• src/fg_apply_tmpl.c
• src/meson.build
• src/x86/filmgrain16_avx2.asm
• src/x86/filmgrain16_sse.asm
• src/x86/filmgrain_avx2.asm
• src/x86/filmgrain_init_tmpl.c
• src/x86/filmgrain_sse.asm
• tests/checkasm/filmgrain.c
• src/fg_apply_tmpl.c
• src/meson.build
• src/x86/filmgrain16_avx2.asm
• src/x86/filmgrain16_sse.asm
• src/x86/filmgrain_avx2.asm
• src/x86/filmgrain_init_tmpl.c
• src/x86/filmgrain_sse.asm
• tests/checkasm/filmgrain.c

---

ba07371c2e590801c391093a07043d5db0e30c95 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/ba07371c2e590801c391093a07043d5db0e30c95
Authored: 2022-02-04 20:09:29 +0100
Committed: 2022-02-28 19:20:47 +0100

Add minor filmgrain scaling generation optimizations

Files Added:

• src/fg_apply_tmpl.c
• src/fg_apply_tmpl.c

---

20e154aa7441ad43d96409fa474be87b1fb64942 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/20e154aa7441ad43d96409fa474be87b1fb64942
Authored: 2022-02-04 19:03:22 +0100
Committed: 2022-02-28 19:20:47 +0100

build: Make "film_grain" vs "filmgrain" DSP file names consistent

Files Added:

• src/decode.c
• src/fg_apply.h
• src/internal.h
• src/meson.build
• tests/checkasm/filmgrain.c
• src/decode.c
• src/fg_apply.h
• src/internal.h
• src/meson.build
• tests/checkasm/filmgrain.c

Files Changed:

• R100 src/arm/32/film_grain.S
• R100 src/arm/32/film_grain16.S
• R100 src/arm/64/film_grain.S
• R100 src/arm/64/film_grain16.S
• R099 src/arm/film_grain_init_tmpl.c
• R100 src/film_grain.h
• R099 src/film_grain_tmpl.c
• R100 src/x86/film_grain16_avx2.asm
• R100 src/x86/film_grain16_sse.asm
• R100 src/x86/film_grain_avx2.asm
• R099 src/x86/film_grain_init_tmpl.c
• R100 src/x86/film_grain_sse.asm
• R100 src/arm/32/film_grain.S
• R100 src/arm/32/film_grain16.S
• R100 src/arm/64/film_grain.S
• R100 src/arm/64/film_grain16.S
• R099 src/arm/film_grain_init_tmpl.c
• R100 src/film_grain.h
• R099 src/film_grain_tmpl.c
• R100 src/x86/film_grain16_avx2.asm
• R100 src/x86/film_grain16_sse.asm
• R100 src/x86/film_grain_avx2.asm
• R099 src/x86/film_grain_init_tmpl.c
• R100 src/x86/film_grain_sse.asm

---

402b54fcaecd424726b3f1292b4fea3c5b1d8e35 by Victorien Le Couviour--Tuffet

https://code.videolan.org/videolan/dav1d-/commit/402b54fcaecd424726b3f1292b4fea3c5b1d8e35
Authored: 2022-02-01 17:44:26 +0100
Committed: 2022-02-28 18:20:48 +0100

Integrate film grain in the task threading system

Files Added:

• src/fg_apply.h
• src/fg_apply_tmpl.c
• src/internal.h
• src/lib.c
• src/thread_task.c
• src/thread_task.h
• src/fg_apply.h
• src/fg_apply_tmpl.c
• src/internal.h
• src/lib.c
• src/thread_task.c
• src/thread_task.h

---

b010080fea75435327fc90824bb4d8035722b3cb by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/b010080fea75435327fc90824bb4d8035722b3cb
Authored: 2022-02-28 00:42:20 +0100
Committed: 2022-02-28 00:57:49 +0100

x86: Fix data being stored below the stack pointer in SSSE3 itx asm

Files Added:

• src/x86/itx_sse.asm
• src/x86/itx_sse.asm

---

cf00849987f052cac3b3e147b8909a7a1348b527 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/cf00849987f052cac3b3e147b8909a7a1348b527
Authored: 2022-02-28 00:41:15 +0100
Committed: 2022-02-28 00:43:30 +0100

x86: Remove redundant labels and undefs in SSSE3 itx asm

Files Added:

• src/x86/itx_sse.asm
• src/x86/itx_sse.asm

---

9124c54b346421231c3b1ea716dc928d678eb558 by Jean-Baptiste Kempf

https://code.videolan.org/videolan/dav1d-/commit/9124c54b346421231c3b1ea716dc928d678eb558
Authored: 2022-02-19 10:30:56 +0100
Committed: 2022-02-27 11:26:48 +0100

NEWS for 1.0.0

Files Added:

• NEWS
• NEWS

---

887fa1d718df42aac1ac102580c14eb655979ac6 by James Almer

https://code.videolan.org/videolan/dav1d-/commit/887fa1d718df42aac1ac102580c14eb655979ac6
Authored: 2022-02-20 20:27:46 -0300
Committed: 2022-02-26 11:13:37 +0000

reset Dav1dDataProps to defaults when unreferencing data and pictures

Files Added:

• src/data.c
• src/picture.c
• src/data.c
• src/picture.c

---

4dd4e919ebd011e9b0989bf444beb24d30e9f9dc by James Almer

https://code.videolan.org/videolan/dav1d-/commit/4dd4e919ebd011e9b0989bf444beb24d30e9f9dc
Authored: 2022-02-20 19:59:45 -0300
Committed: 2022-02-26 11:13:37 +0000

obu: make all parsing errors use the same error path

Files Added:

• src/obu.c
• src/obu.c

---

3e12be7331626ea1937dc2a50a7da8be34ebade7 by James Almer

https://code.videolan.org/videolan/dav1d-/commit/3e12be7331626ea1937dc2a50a7da8be34ebade7
Authored: 2022-02-25 23:32:53 -0300
Committed: 2022-02-25 23:32:53 -0300

lib: remove some unnecessary brackets

Cosmetic change

Files Added:

• src/lib.c
• src/lib.c

---

54a4dbb573965b78714b14f7ac11547ebf70db7a by Wan-Teh Chang

https://code.videolan.org/videolan/dav1d-/commit/54a4dbb573965b78714b14f7ac11547ebf70db7a
Authored: 2022-02-25 11:03:12 -0800
Committed: 2022-02-25 19:55:09 +0000

Remove redundant unref of c->in in close_internal

The dav1d_data_unref_internal(&c->in) call in close_internal() is
redundant because dav1d_flush() already calls
dav1d_data_unref_internal(&c->in).

Note that when dav1d_open() calls close_internal() with flush=0 to free
a newly constructed Dav1dContext, it is not necessary to unref c->in.

Files Added:

• src/lib.c
• src/lib.c

---

65953c862d392868d167ae6c4327d869da8a98ea by Wan-Teh Chang

https://code.videolan.org/videolan/dav1d-/commit/65953c862d392868d167ae6c4327d869da8a98ea
Authored: 2022-02-25 10:00:31 -0800
Committed: 2022-02-25 11:36:58 -0800

Unreference c->cache in dav1d_flush()

Fix memory leaks. The 'Dav1dThreadPicture cache' member was added to
struct Dav1dContext in commit f9844476372719fd1acc2a6dec51ca65fa74bbcf.
But it is not unreferenced in dav1d_flush() or dav1d_close().

James Almer pointed out that we should unreference c->out too in
dav1d_flush().

Files Added:

• src/lib.c
• src/lib.c

---

5f8de654d46fbe95967c5603c25b935d3e08b1b1 by Wan-Teh Chang

https://code.videolan.org/videolan/dav1d-/commit/5f8de654d46fbe95967c5603c25b935d3e08b1b1
Authored: 2022-02-23 20:33:18 -0800
Committed: 2022-02-24 18:49:49 -0800

Assign 8bpc avx2 functions if BITDEPTH == 8

This restores the behavior before
commit eb0308bcdf1bfd651f2359ed49a2f6dc258aed86 if BITDEPTH == 8.

Files Added:

• src/x86/itx_init_tmpl.c
• src/x86/itx_init_tmpl.c

---

e2e2a7963046ed56b5ec73f85d6e30fe88ddd33f by Wan-Teh Chang

https://code.videolan.org/videolan/dav1d-/commit/e2e2a7963046ed56b5ec73f85d6e30fe88ddd33f
Authored: 2022-02-22 17:49:40 -0800
Committed: 2022-02-22 17:49:40 -0800

Always initialize b->uv_angle in decode_b()

Initialize b->uv_angle to 0 in decode_b(). Fixes a MSan
use-of-uninitialized-value warning about b->uv_angle in
dav1d_recon_b_intra_16bpc(), reported by ClusterFuzz.

Files Added:

• src/decode.c
• src/decode.c

---

7e91b59fe79c13b6007aade411da6d98b31ed202 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/7e91b59fe79c13b6007aade411da6d98b31ed202
Authored: 2022-02-21 23:16:52 +0100
Committed: 2022-02-21 23:16:52 +0100

x86: Update x86inc.asm

Files Added:

• src/ext/x86/x86inc.asm
• src/x86/cdef16_avx2.asm
• src/x86/cdef16_sse.asm
• src/x86/film_grain16_avx2.asm
• src/x86/film_grain16_sse.asm
• src/x86/film_grain_avx2.asm
• src/x86/film_grain_sse.asm
• src/x86/ipred16_avx2.asm
• src/x86/ipred16_avx512.asm
• src/x86/ipred16_sse.asm
• src/x86/itx16_avx2.asm
• src/x86/itx16_sse.asm
• src/x86/itx_avx2.asm
• src/x86/itx_avx512.asm
• src/x86/itx_sse.asm
• src/x86/loopfilter16_avx2.asm
• src/x86/loopfilter16_sse.asm
• src/x86/looprestoration16_avx2.asm
• src/x86/mc16_avx2.asm
• src/x86/mc16_avx512.asm
• src/x86/mc16_sse.asm
• src/x86/mc_avx512.asm
• src/ext/x86/x86inc.asm
• src/x86/cdef16_avx2.asm
• src/x86/cdef16_sse.asm
• src/x86/film_grain16_avx2.asm
• src/x86/film_grain16_sse.asm
• src/x86/film_grain_avx2.asm
• src/x86/film_grain_sse.asm
• src/x86/ipred16_avx2.asm
• src/x86/ipred16_avx512.asm
• src/x86/ipred16_sse.asm
• src/x86/itx16_avx2.asm
• src/x86/itx16_sse.asm
• src/x86/itx_avx2.asm
• src/x86/itx_avx512.asm
• src/x86/itx_sse.asm
• src/x86/loopfilter16_avx2.asm
• src/x86/loopfilter16_sse.asm
• src/x86/looprestoration16_avx2.asm
• src/x86/mc16_avx2.asm
• src/x86/mc16_avx512.asm
• src/x86/mc16_sse.asm
• src/x86/mc_avx512.asm

---

d821d88035aee149a3b6e4d1b1876f080ad8adab by Matthias Dressel

https://code.videolan.org/videolan/dav1d-/commit/d821d88035aee149a3b6e4d1b1876f080ad8adab
Authored: 2022-02-19 18:01:31 +0100
Committed: 2022-02-19 18:01:31 +0100

Update THANKS.md

Files Added:

• THANKS.md
• THANKS.md

---

6ed0802d2059351130a895339d42628b5af3ce7a by Jean-Baptiste Kempf

https://code.videolan.org/videolan/dav1d-/commit/6ed0802d2059351130a895339d42628b5af3ce7a
Authored: 2022-02-19 10:17:05 +0100
Committed: 2022-02-19 14:19:15 +0100

Update README for 1.0

Files Added:

• README.md
• README.md

---

8ccdf0f6b91e43b589c195151ec3bffb3db417f1 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/8ccdf0f6b91e43b589c195151ec3bffb3db417f1
Authored: 2022-02-16 17:41:38 -0500
Committed: 2022-02-17 08:46:22 -0500

task_thread: use EINVAL/ENOMEM instead of -1 for f->task_thread.retval

Files Added:

• src/thread_task.c
• src/thread_task.c

---

2a00fb6d4746a9bd0c15e0dcbcb148ce0b3e681d by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/2a00fb6d4746a9bd0c15e0dcbcb148ce0b3e681d
Authored: 2022-02-16 17:40:37 -0500
Committed: 2022-02-17 08:46:19 -0500

Forward frame-thread decoding errors back to user thread

Files Added:

• src/decode.c
• src/internal.h
• src/lib.c
• src/obu.c
• src/decode.c
• src/internal.h
• src/lib.c
• src/obu.c

---

00d4715ca2a16f41f5cec2118c6333ce99067f07 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/00d4715ca2a16f41f5cec2118c6333ce99067f07
Authored: 2022-02-16 17:34:41 -0500
Committed: 2022-02-16 18:00:27 -0500

decode.c: remove dead assignment

Files Added:

• src/decode.c
• src/decode.c

---

239c951f2e2767770a08a9d728847da632696533 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/239c951f2e2767770a08a9d728847da632696533
Authored: 2022-02-16 17:36:46 -0500
Committed: 2022-02-16 18:00:20 -0500

decode.c: fix return value on bitstream decoding errors

Change ENOMEM into EINVAL, since at this point memory allocation
errors don't occur, and bitstream decoding errors are not fatal.

Files Added:

• src/decode.c
• src/decode.c

---

cae2c4f0bdd5285a2ee13e385f4474729948da10 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/cae2c4f0bdd5285a2ee13e385f4474729948da10
Authored: 2022-02-16 17:36:19 -0500
Committed: 2022-02-16 18:00:09 -0500

tools/dav1d: fix infinite loop on corrupt bitstreams

Unref data after decoding failure to prevent re-entering the loop
with the same data.

Files Added:

• tools/dav1d.c
• tools/dav1d.c

---

94b1bf456e9062a2f966453b1daea3fd6a9e03cc by Matthias Dressel

https://code.videolan.org/videolan/dav1d-/commit/94b1bf456e9062a2f966453b1daea3fd6a9e03cc
Authored: 2022-02-09 15:35:09 +0100
Committed: 2022-02-09 15:35:09 +0100

meson: Use native check of return value

Files Added:

• meson.build
• meson.build

---

2131a2cdaf5d14495ff7f26c0f40232cacdfa561 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/2131a2cdaf5d14495ff7f26c0f40232cacdfa561
Authored: 2022-02-09 07:17:30 -0500
Committed: 2022-02-09 13:21:28 +0000

Fix typo in EINVAL comparison

Files Added:

• tools/dav1d.c
• tools/dav1d.c

---

a00289b6d8ebf0ffef9b2c08c0c63b7ad330fa47 by André Kempe

https://code.videolan.org/videolan/dav1d-/commit/a00289b6d8ebf0ffef9b2c08c0c63b7ad330fa47
Authored: 2022-01-28 11:38:38 +0000
Committed: 2022-02-09 12:20:17 +0000

arm64: Add Armv8.3-A PAC support to assembly files

This patch adds optional support for Arm Pointer Authentication Codes.

PAC support is turned on or off at compile time using additional
compiler flags. Unless any of these is enabled explicitly, no additional
code will be emitted at all.

Files Added:

• src/arm/64/film_grain.S
• src/arm/64/film_grain16.S
• src/arm/64/looprestoration.S
• src/arm/64/looprestoration16.S
• src/arm/asm.S
• src/arm/64/film_grain.S
• src/arm/64/film_grain16.S
• src/arm/64/looprestoration.S
• src/arm/64/looprestoration16.S
• src/arm/asm.S

---

02b8876eb9c03ac7e31ea03742f12bd7a6ed77d2 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/02b8876eb9c03ac7e31ea03742f12bd7a6ed77d2
Authored: 2022-02-02 03:45:25 +0100
Committed: 2022-02-08 15:04:19 +0100

x86: Add high bit-depth ipred filter AVX-512 (Ice Lake) asm

Files Added:

• src/tables.c
• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c
• src/tables.c
• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c

---

79fed8ae709c63760820ed0a7fac1833e8ada313 by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/79fed8ae709c63760820ed0a7fac1833e8ada313
Authored: 2022-02-02 03:45:23 +0100
Committed: 2022-02-08 15:03:10 +0100

x86: Add high bit-depth pal_pred AVX-512 (Ice Lake) asm

Files Added:

• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c
• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c

---

1dbc62dee4d4bfb0ebe9df3cdd1050980e6716cf by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/1dbc62dee4d4bfb0ebe9df3cdd1050980e6716cf
Authored: 2022-02-02 03:45:21 +0100
Committed: 2022-02-08 15:03:10 +0100

x86: Add high bit-depth ipred smooth AVX-512 (Ice Lake) asm

Files Added:

• src/x86/ipred16_avx2.asm
• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c
• src/x86/ipred16_avx2.asm
• src/x86/ipred16_avx512.asm
• src/x86/ipred_init_tmpl.c

---

e127db2fa45f4fff721ebb7f5163057246fc052c by Henrik Gramner

https://code.videolan.org/videolan/dav1d-/commit/e127db2fa45f4fff721ebb7f5163057246fc052c
Authored: 2022-02-02 03:45:18 +0100
Committed: 2022-02-08 15:03:10 +0100

x86: Add high bit-depth ipred paeth AVX-512 (Ice Lake) asm

Files Added:

• src/x86/ipred16_avx512.asm
• src/x86/ipred16_avx512.asm

Files Added:

• src/meson.build
• src/x86/ipred_init_tmpl.c
• src/meson.build
• src/x86/ipred_init_tmpl.c

---

a363374a83b5961b2526e5e241272f260246e780 by Ronald S. Bultje

https://code.videolan.org/videolan/dav1d-/commit/a363374a83b5961b2526e5e241272f260246e780
Authored: 2022-02-07 13:03:49 -0500
Committed: 2022-02-07 13:39:58 -0500

tools/dav1d: continue on recoverable bitstream decoding errors

Fixes inconsistent output frame count depending on --threads=X value
for the sample in #244.

Files Added:

• tools/dav1d.c
• tools/dav1d.c

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd27fe2e3372baea8a091d6b3b8686b2216afdf0

Comment 2

[Update Bot]

Attachment: Bug 1758482 - Update dav1d to 5fb9f3a4601e170dc082dc5b30966d02535f9fe9

Comment 3

[Jon Bauman [:jbauman:]]

(In reply to Update Bot from comment #1)

I've submitted a try run for this commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd27fe2e3372baea8a091d6b3b8686b2216afdf0

This run looks pretty well borked. Rather than try to debug it, per the request of the dav1d developers, I'm going to update to a newer version manually in order to address 1757971.

Comment 4

[Jon Bauman [:jbauman:]]

On top of the changes that updatebot mentioned in comment 0, I'm manually adding 6 additional commits:

commit 28a9c46e1c36540d3276299f2e284ece1d2386be (HEAD -> master, origin/master, origin/HEAD)
Author: Martin Storsjö <[e-mail]>
Date: Wed Mar 9 12:02:43 2022 +0200

arm: Only produce the PAC/BTI .note section when targeting ELF

This avoids build errors if such features are enabled while targeting
another binary format. (Using such features on other platforms
might require some other form of signaling/setup though, but
the ELF specific .note section isn't applicable at least.)

commit 032aa1cb9b4b8bfada8510fec0227bec88970082
Author: Martin Storsjö <[e-mail]>
Date: Wed Mar 9 12:01:57 2022 +0200

arm: Add comments to #endif and #else in nonobvious cases

commit b6bd4007ccb3456d79646845dc745f6eafe1bb29
Author: Ronald S. Bultje <[e-mail]>
Date: Wed Mar 9 14:33:11 2022 -0500

lib.c: re-order so all code accessing f->* is grouped together

commit 493ffb12f77df791f7dcde991b92d64bf873fefd
Author: James Almer <[e-mail]>
Date: Tue Mar 8 15:52:10 2022 -0300

lib: add a public function to return the props from the last frame that failed to decode

commit 3d3c51a07cc3dd1e3687da40fdb6fbb857cbced1
Author: James Almer <[e-mail]>
Date: Tue Mar 8 15:23:50 2022 -0300

data: add a public function to release a Dav1dDataProps reference

commit b6bec5b453dd7ef49b81a016fcdbfc7c157c6a66
Author: Ronald S. Bultje <[e-mail]>
Date: Tue Mar 8 10:27:09 2022 -0500

lib.c: consider a cached_error as a valid output picture

Fixes #277.

Changes for 1.0.0 'Peregrine falcon':

1.0.0 is a major release of dav1d, adding important features and bug fixes.

It notably changes, in an important way, the way threading works, by adding
an automatic thread management.

It also adds support for AVX-512 acceleration, and adds speedups to existing x86
code (from SSE2 to AVX2).

1.0.0 adds new grain API to ease acceleration on the GPU.

Finally, 1.0.0 fixes numerous small bugs that were reported since the beginning
of the project to have a proper release.

Comment 5

[Jon Bauman [:jbauman:]]

Attachment: Bug 1758482 - Update dav1d to new version 28a9c46e1c36540d3276299f2e284ece1d2386be from 2022-02-04T23:02:17.000-03:00.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ec8035de8c8
Update dav1d to new version 28a9c46e1c36540d3276299f2e284ece1d2386be from 2022-02-04T23:02:17.000-03:00. r=media-playback-reviewers,padenot

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0ec8035de8c8

Comment 8

[Jon Bauman [:jbauman:]]

Comment on attachment 9267534 [details]
Bug 1758482 - Update dav1d to new version 28a9c46e1c36540d3276299f2e284ece1d2386be from 2022-02-04T23:02:17.000-03:00.

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1757971: "Video is frozen after seeking on youtube.com" will remain unfixed in release
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The defect is well-understood by the dav1d developers and this update contains the fix. Also this updates to their 1.0 release candidate which is more thoroughly tested than either the revision we're at currently or the revision we'd be going back to if we addressed Bug 1757971 by reverting the previous update (bug 1754070)
• String changes made/needed:

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9266842 [details]
Bug 1758482 - Update dav1d to 5fb9f3a4601e170dc082dc5b30966d02535f9fe9

Approved

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9267534 [details]
Bug 1758482 - Update dav1d to new version 28a9c46e1c36540d3276299f2e284ece1d2386be from 2022-02-04T23:02:17.000-03:00.

Approved for 99.0b5. Thanks.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/25697a940cbf

Comment 12

[Arthur K. (he/him)]

I just saw that the final dav1d release just got pushed out a few hours ago. 28a9c46e1c36540d3276299f2e284ece1d2386be is an RC, right?

Comment 13

[Jon Bauman [:jbauman:]]

I just saw that the final dav1d release just got pushed out a few hours ago. 28a9c46e1c36540d3276299f2e284ece1d2386be is an RC, right?
That is my understanding, yes

Comment 14

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).