1758684 - ./mach wpt-update ../logs/* --update-intermittent doesn't update wpt expectation .ini files when it should for one specific task

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

~/mozilla/fetchlogs $ cargo run mozilla-central 11820f4551ab30b94ff80685ed0a4690eadbb0e8  --out-dir ../logs/ --filter-jobs test-linux1804-32-shippable-qr/opt-web-platform-tests-fis-e10s-9
./mach wpt-update ../logs/* --update-intermittent

doesn't update any test expectation files but there are unexpected results for Linux 32-bit.
Note Test harness output was not a valid structured log message: gets also logged.

Comment 1

[James Graham [:jgraham]]

It seems like we're failing to mark the test as modified in this case where only a subtest changes, so we don't write the update. But I'm not sure why this is only broken sometimes and not in any case where the overall test didn't require updates.

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1758684 - Inherit modified flag from subtests when updating wpt metadata,

The wpt-update code ensures that it only writes data in cases the file
is changed by having a 'modified' flag on each metadata file. However
this wasn't being correctly set on the manifest in the case that only
a subtest was modified, and not a top level test.

It turns out that in the existing code the test modified flag is
usually set anyway, except in the case that the test itself has a
conditional status that doesn't require an update. Therefore this
wasn't caught by any of the tests, and hadn't caused lots of issues
with updates.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24c5f6b62ba2
Inherit modified flag from subtests when updating wpt metadata, r=karlcow

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/24c5f6b62ba2

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33255 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot