1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Comment 1

[Tim Huang[:timhuang]]

We can use the foreignPartitionedPrincipal for the purpose of the new principal we want to build here.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r?bvandersloot!

Depends on D143626

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bc1291b9bdb
Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=twisniewski

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_storage_dfpi.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6385b1d5ea2227364861041541357abc0436bc10

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a3024e8b2a58d6e08cde5099fca19d05060329b4&selectedTaskRun=O8W7nUBqQsymlco-OnN9tg.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=377549673&repo=autoland&lineNumber=37937
https://treeherder.mozilla.org/logviewer?job_id=377550008&repo=autoland&lineNumber=3584

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9daa04b239f9
Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=twisniewski

Comment 6

[Cristian Tuns]

Backed out for causing mochitest failures on test_storagePermissionsAccept.html

• Backout link
• Push with failures
• Failure Log
• Failure Log2
• Failure Log3
• Failure Log4
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_storagePermissionsAccept.html | getting localStorage should not throw

Comment 7

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:twisniewski, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5261ee5a2368
Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_storage_copied

Backout link

Push with failures

Failure log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b7641683b0
Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot

Comment 11

[Cristian Tuns]

Backed out for causing mochitest failures on browser_partitionedConsoleMessage.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_partitionedConsoleMessage.js | Test timed out -

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df0bef4f7b18
Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/df0bef4f7b18