1758781 - Build llvm-symbolizer separately

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Description

[Mike Hommey [:glandium]]

The llvm-symbolizer tasks currently extract a llvm-symbolizer from clang tasks. Changes in clang 14 make the hack that we have in place to keep llvm-symbolizer statically linked to libllvm while clang uses a dynamic libllvm not work anymore, so it's time to bite the bullet and build llvm-symbolizer separately.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1758781 - Use the WinMsvc.cmake toolchain file to build compiler-rt.

The toolchain file is a helper for cross-compilation that even deals
with case-sensivity in MSVC, which simplifies our setup.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1758781 - Build llvm-symbolizer separately.

The llvm-symbolizer tasks currently extract a llvm-symbolizer from clang
tasks. Changes in clang 14 make the hack that we have in place to keep
llvm-symbolizer statically linked to libllvm while clang uses a dynamic
libllvm not work anymore, so it's time to bite the bullet and build
llvm-symbolizer separately.

We share most of the build setup with the compiler-rt build.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1758781 - Remove now unnecessary patch to link llvm-symbolizer statically.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78117d649b5d
Use the WinMsvc.cmake toolchain file to build compiler-rt. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/68b936acd34c
Build llvm-symbolizer separately. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/4365905c4c1a
Remove now unnecessary patch to link llvm-symbolizer statically. r=firefox-build-system-reviewers,mhentges

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aa0eb5e74f8
fix for build bustages. CLOSED TREE

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/78117d649b5d
https://hg.mozilla.org/mozilla-central/rev/68b936acd34c
https://hg.mozilla.org/mozilla-central/rev/4365905c4c1a
https://hg.mozilla.org/mozilla-central/rev/3aa0eb5e74f8

Comment 7

[Jim Blandy :jimb]

This seems to be causing build problems for me on Fedora. I'll attach error output.

Comment 8

[Jim Blandy :jimb]

Attachment: Error log from mach