Closed Bug 1758788 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 33136 - [css-flex] Handle frame flex items out of band

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33136 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33136
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Handle frame flex items out of band

Our engine gives frame elements that aren't children of framesets a size
of 0x0, even ignoring border+padding. But flex has bunch of DCHECKs that
assert various sizes are >= border+padding. But frames trip them a lot
because we ignore their border+padding.

This patch makes frame flex items not go through the normal flex item
layout path, but instead just gives them size 0x0 right away and is done
with them.

Fixed: 1294530
Change-Id: I835baef7b5525f106c8b72dadaf674c2362125c5

Reviewed-on: https://chromium-review.googlesource.com/3513891
WPT-Export-Revision: 480705b14d2e416ddded7e77326a2b3472099458

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.