Closed Bug 1758817 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33143 - [FlexNG] Multi-line column flex item expansion

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33143 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33143
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Multi-line column flex item expansion

As a result of CL:3290486, no special logic was needed to handle
expansion for items in a multi-line vs single-line column flex
container. Thus, add tests for the multi-line column case.

One bug with the iterator was uncovered while testing - in
NextLine() we weren't making use of next_item_idx_for_line_ and would
potentially re-traverse an item that had already been traversed with
its break token. This is now fixed.

Unrelatedly, multi-line-row-flex-fragmentation-016.html was updated
to adjust one of the OOF's offset and height to avoid overlap
with the previous row.

Bug: 660611
Change-Id: I92debb2d5c38b4d610219c387e74d476f7c10d7e
Reviewed-on: https://chromium-review.googlesource.com/3513328
WPT-Export-Revision: 1892bbcba1f9ae3a278c923c19e2f4be0da6f75f

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 1
FAIL: 5

Chrome

PASS: 3
FAIL: 3

Safari

PASS: 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/multi-line-column-flex-fragmentation-012.html: FAIL
/css/css-break/flexbox/multi-line-column-flex-fragmentation-013.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-column-flex-fragmentation-012.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-013.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-015.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-016.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-016.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/905243cc123d [wpt PR 33143] - [FlexNG] Multi-line column flex item expansion, a=testonly https://hg.mozilla.org/integration/autoland/rev/65131ca47641 [wpt PR 33143] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c72b17e5f49e [wpt PR 33143] - [FlexNG] Multi-line column flex item expansion, a=testonly https://hg.mozilla.org/integration/autoland/rev/38360da7b168 [wpt PR 33143] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.