17589 - "delete user" currently not a good idea

Status: RESOLVED FIXED

(Webtools Graveyard :: Despot, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

as it may leave dangling pointers, esp. in the members and changes tables.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This has the side-effect that sending mail to all despot users generates bunches
of bounces.

Comment 2

[Zach Lipton [:zach]]

Can we just get rid of :

375     print MyForm("DeleteUser") . hidden(-name=>"email");
376     print submit("Delete user");

and

381 sub DeleteUser() {
382     my $q = SqlQuote($F::email);
383     Query("delete from users where email = '$q'");
384     Query("insert into syncneeded (needed) values (1)");
385     print h1("OK, $F::email is gone.");
386     print hr();
387     MainMenu();
388 }


This disables the delete user code (better yet comment it out so it can 
come back again easily) We should fix the problems with deleting users, 
but if it causes problems in the tables, and a user can be suspended 
which does the same ammount of good, it is a lower priority then just 
taking out the feature.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I've disabled this as Zach suggested to help avoid database corruption until a
fix happens.  Resetting the bug state to NEW, as I'm not actively working on
this at the moment.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Mass re-assign of despot bugs to [e-mail], the new owner.  I'm
switching groups to go work on mozilla LDAP integration.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Another try at mass-reassigning my Despot bugs to endico.

Comment 6

[Dave Miller [:justdave]]

reassigning endico's Despot bugs to the default component owner

Comment 7

[timeless]

note that Delete User is currently disabled in cvs:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/despot/despot.cgi&rev=1.22&root=/cvsroot&mark=376-394#370

Comment 8

[Reed Loden [:reed]]

Attachment: patch - v1

To fix referential integrity problems, the user must be deleted from both the members and users table. This patch first converts the e-mail address to the id and checks to make sure it is valid. Afterwards, it deletes the user from both the members and users table. In the end, it adds an entry to the changes table acting like the admin has changed the "deleted" flag for the user from 'No' to 'Yes'.

Comment 9

[Reed Loden [:reed]]

NOTE: You have to set $EnableDeleteUser to 1 for this to actually work. I'd prefer to just drop that variable completely now that the function works. It seems it was added in bug 320105.

Comment 10

[Reed Loden [:reed]]

Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.45; previous revision: 1.44
done