1759031 - New wpt failures in /css/selectors/invalidation/user-action-pseudo-classes-in-has.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 32950 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/selectors/invalidation/user-action-pseudo-classes-in-has.html
Invalidation with :focus, :focus-within, :focus-visible in :has(): FAIL (Chrome: FAIL, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1756776 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[David Shin[:dshin]]

The framework being used is not supported by us, it seems:

Uncaught (in promise) Error: action_sequence() is not implemented by testdriver-vendor.js
    action_sequence http://127.0.0.1:8000/resources/testdriver.js:906
    action_sequence http://127.0.0.1:8000/resources/testdriver.js:395
    send http://127.0.0.1:8000/resources/testdriver-actions.js:99
    <anonymous> http://127.0.0.1:8000/css/selectors/invalidation/user-action-pseudo-classes-in-has.html:116

Comment 2

[James Graham [:jgraham]]

The error message I see is assert_equals: subject1 should be skyblue expected "rgb(135, 206, 235)" but got "rgb(0, 0, 255)".

As noted in the other issue we definitely implement testdriver support. Are you running via mach wpt or trying to load the test manually using mach wpt-serve? The latter doesn't work for these tests.

Comment 3

[David Shin[:dshin]]

Ah, ok, that's my bad - wpt-hosted test does the same so that's what I thought was more accurate.

Comment 4

[David Shin[:dshin]]

Ah... The current failure mode can be explained by bug 1293741.
As that bug implies, it has more to do with how we handle :active more so than :has.

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1759031: Let `user-action-pseudo-classes-in-has.html` rely on actions being completed. r=emilio

Previously, the test relied upon event listener to listen to related events:
e.g. mousedown event on Actions().pointerDown(). However, as comments in
https://github.com/whatwg/html/issues/7578 indicate when :active matches
does not seem to be interoperable across browsers with different inputs.
Instead rely on the action sequence being completed, as done with a simliar
test, html/semantics/selectors/pseudo-classes/active-disabled.html.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab075d8118ae
Let `user-action-pseudo-classes-in-has.html` rely on actions being completed. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43122 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

Backed out for causing failures at user-action-pseudo-classes-in-has.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/81ff244b9258cbd0f276f9a2d57613d9055d9be9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ab075d8118aecde5cf88872225b85effcfffbacb&selectedTaskRun=Yhe7yxRwSVymIydn-XV1jA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=436127183&repo=autoland&lineNumber=4862

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adc6a6f51dfa
Let `user-action-pseudo-classes-in-has.html` rely on actions being completed. r=emilio

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/adc6a6f51dfa

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot