Closed Bug 1759045 Opened 5 months ago Closed 5 months ago

Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.gfx.SurfaceAllocator.acquireSurface(SurfaceAllocator.java)]

Categories

(Core :: Audio/Video: Playback, defect)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox98 + fixed
firefox99 + fixed
firefox100 + fixed

People

(Reporter: ryanvm, Assigned: jnicol)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Crash report: https://crash-stats.mozilla.org/report/index/24ae9dfd-6ed7-4d9d-8b0a-f3b900220310

Currently the #1 overall topcrash in Fenix 99.0.0-beta.1 and #3 overall for 98.1.1. Regression from bug 1750234 maybe?

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.SurfaceAllocator.acquireSurface(SurfaceAllocator.java:8)
Flags: needinfo?(jnicol)

The timing of these crashes corresponds exactly with bug 1750234.

Keywords: regression
Regressed by: 1750234

Ugh, I added some code that uses the object before the null check. Not very clever of me.

Flags: needinfo?(jnicol)

This prevents a java NullPointerException when the
RemoteSurfaceAllocator returns a null Surface to the local
SurfaceAllocator instance.

Assignee: nobody → jnicol
Status: NEW → ASSIGNED
Has Regression Range: --- → yes

This is quickly turning into a topcrash for 98. We should keep it on the radar for a dot release.

Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51d0da5f8d2b
Add null check to SurfaceAllocator.acquireSurface. r=agi

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Beta/Release Uplift Approval Request

  • User impact if declined: Content process crashes on android
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Adds null check before using object. The calling code already handles a null return, this just guards against null before using the object for some recently added code.
  • String changes made/needed:
Attachment #9267322 - Flags: approval-mozilla-release?
Attachment #9267322 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Approved for 99.0b3. Thanks.

Attachment #9267322 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Approved for Fenix/Focus 98.3.0.

Attachment #9267322 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.