1759045 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.gfx.SurfaceAllocator.acquireSurface(SurfaceAllocator.java)]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Crash report: https://crash-stats.mozilla.org/report/index/24ae9dfd-6ed7-4d9d-8b0a-f3b900220310

Currently the #1 overall topcrash in Fenix 99.0.0-beta.1 and #3 overall for 98.1.1. Regression from bug 1750234 maybe?

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.SurfaceAllocator.acquireSurface(SurfaceAllocator.java:8)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

The timing of these crashes corresponds exactly with bug 1750234.

Comment 2

[Jamie Nicol [:jnicol]]

Ugh, I added some code that uses the object before the null check. Not very clever of me.

Comment 3

[Jamie Nicol [:jnicol]]

Attachment: Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

This prevents a java NullPointerException when the
RemoteSurfaceAllocator returns a null Surface to the local
SurfaceAllocator instance.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This is quickly turning into a topcrash for 98. We should keep it on the radar for a dot release.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d0da5f8d2b
Add null check to SurfaceAllocator.acquireSurface. r=agi

Comment 6

[Jamie Nicol [:jnicol]]

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Beta/Release Uplift Approval Request

• User impact if declined: Content process crashes on android
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds null check before using object. The calling code already handles a null return, this just guards against null before using the object for some recently added code.
• String changes made/needed:

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/51d0da5f8d2b

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Approved for 99.0b3. Thanks.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22613ba2eadc

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9267322 [details]
Bug 1759045 - Add null check to SurfaceAllocator.acquireSurface. r?agi

Approved for Fenix/Focus 98.3.0.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/bd2e0215d335