1759047 - MozillaBuild 4.0pre0: Git's paging is broken

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, defect)

Description

[Ray Kraesig [:rkraesig]]

Git for Windows ships with its own MSYS, including its own less. This works fine in Git Bash, but not so much in MozillaBuild's MSYS2; the visible effect of this is that git commands which trigger less will result in less not understanding the up- or down-arrow keys.

This can be alleviated by setting core.pager to MozillaBuild's less by specifying the full Windows path thereto. (Note that /usr/bin/less is interpreted by Git to mean its own /usr/bin/less, not necessarily the enclosing MSYS environment's!)

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Good find, thanks!

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

This is proving to be pretty tricky. Here's some findings so far:

• MozillaBuild 3.4: git log works
• As reported, MozillaBuild 4.0pre0: git log: arrow keys make dinging noise, but doesn't move pager up and down
• MozillaBuild 4.0 with custom-built Git-for-Windows: /c/git-sdk-64/path/to/built/mingw/git.exe log: arrow keys work (?)
• MozillaBuild 4.0 with Git-for-Windows, using upstream's shipped mingw git wrapper: /c/git-sdk-64/cmd/git log: arrow keys still work (?)

I'm really shocked that the SDK's git works, especially since it and my real git installation are both 2.35.1 (though the sdk probably has some sort of prerelease git, but it shouldn't be that different).
The next steps I have are:

• Try hitting official git via a default MSYS2 shell (using Command Prompt, not Mintty). If this works, then I can simply diff MSYS2 and MozillaBuild 4.0pre0, which should be easy
• If ^ doesn't work, then I need to determine the difference between the Git SDK's mingw git wrapper vs official git's mingw wrapper, then dive in - likely doing git builds and all sorts of nonsense. This could take a significant amount of time to do (week+)

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Try hitting official git via a default MSYS2 shell (using Command Prompt, not Mintty). If this works, then I can simply diff MSYS2 and MozillaBuild 4.0pre0, which should be easy

This also fails for the same reason, I'll file an upstream bug

then I need to determine the difference between the Git SDK's mingw git wrapper vs official git's mingw wrapper, then dive in - likely doing git builds and all sorts of nonsense

Fortunately, there's another workaround: though we don't have access to any git config files, we can influence behaviour via environment variable - such as GIT_PAGER.

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Upstream issue created here.

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1759047: Use MozillaBuild's less as GIT_PAGER

To avoid upstream issue around using Git-for-Windows' bundled less,
lets explicitly use //our// bundled less when using MozillaBuild.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/c1be1f31b182
Use MozillaBuild's less as GIT_PAGER r=ahochheiden