1759167 - Revert the CreatorsUpdate Restriction on Win32k Lockdown

Status: REOPENED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

This was needed while we fixed Bug 1755979 ; but now that that has landed it is no longer needed.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1759167: Revert the CreatorsUpdate restriction on Win32k Lockdown r?bobowen

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

[Tracking Requested - why for this release]: We'd like to uplift this to beta so we can run the win32k experiment there.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/356deee0a23a
Revert the CreatorsUpdate restriction on Win32k Lockdown r=bobowen

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/356deee0a23a

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out as requested for causing crashes.

• backout: https://hg.mozilla.org/mozilla-central/rev/0d575f9dc4a5781f24bf46459375cd8892b233ad

Comment 6

[Donal Meehan [:dmeehan]]

:tjr we are entering the last week of beta for 99, can this wait until 100 goes to beta?

Comment 7

[Bob Owen (:bobowen)]

We still got a load of crashes because of other things loading user32.dll before we initialised COM.
I'm going to see if we can initialise the MTA much earlier, in a similar way that we do for the STA in the main process.
In addition I'm going to look into detecting the load of user32.dll and initialise COM first or wait for it to initialise if we are in a different thread.

I don't think we should be tracking this for 99.
Possibly not 100 either, but I'll see once I've got something working.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bobowen, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 9

[Bob Owen (:bobowen)]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #8)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bobowen, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

We need to fix some things alongside this, should have a patch up soon.
Oh and I don't think we should track this bug, you could argue that it is more of an enhancement than defect.