1759201 - Add a mozilla::TextRecognition component

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Greg Tatum [:gregtatum]]

As part of the exploration work, this a prototype for calling out to OS-level text recognition APIs.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: WIP: Bug 1759201 - Add a nsTextRecognition component

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: WIP: Bug 1759201 - Prototype a menu button click demo for text recognition

Depends on D140874

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Let's not call it nsTextRecognition? Just mozilla::TextRecognition unless there's a good reason for the ns prefix? :)

Comment 4

[Greg Tatum [:gregtatum]]

I'm happy to rename it, as I was just cargo culting from the surrounding code.

Comment 5

[Phabricator Automation]

Comment on attachment 9267442 [details]
WIP: Bug 1759201 - Add a nsTextRecognition component

Revision D140874 was moved to bug 1759504. Setting attachment 9267442 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9267443 [details]
WIP: Bug 1759201 - Prototype a menu button click demo for text recognition

Revision D140875 was moved to bug 1759504. Setting attachment 9267443 [details] to obsolete.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1759201 - Add a text recognition component. r=dminor,gregtatum

This adds just the boilerplate, and doesn't implement the OS-specific
bits. It's still useful tho.

Co-Authored-By: Greg Tatum <[e-mail]>

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1759201 - Add a text recognition component. r=dminor

This adds just the boilerplate, and doesn't implement the OS-specific
bits. It's still useful tho.

Co-Authored-By: Greg Tatum <[e-mail]>

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c9bf312a6f
Add a text recognition component. r=dminor,gregtatum

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for causing xpcshell failures on test_ext_contexts_gc.js

• backout: https://hg.mozilla.org/integration/autoland/rev/d2041a6772f7bac480c1c95496383fb99badbed7
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Q8lxqd_2T5Sp21DRtygNLQ.0&revision=a9c9bf312a6f091b562e7a7e783584b2b3d536c3
• failure log: https://treeherder.mozilla.org/logviewer?job_id=371030056&repo=autoland&lineNumber=1639

[task 2022-03-14T22:59:38.900Z] 22:59:38     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js
[task 2022-03-14T23:04:38.989Z] 23:04:38  WARNING -  TEST-UNEXPECTED-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js | Test timed out
[task 2022-03-14T23:04:38.989Z] 23:04:38     INFO -  TEST-INFO took 300089ms
[task 2022-03-14T23:04:38.989Z] 23:04:38     INFO -  >>>>>>>
[task 2022-03-14T23:04:38.990Z] 23:04:38     INFO -  PID 2888 | [Parent 2888, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2967
[task 2022-03-14T23:04:38.990Z] 23:04:38     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-03-14T23:04:38.990Z] 23:04:38     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-03-14T23:04:38.990Z] 23:04:38     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-03-14T23:04:38.990Z] 23:04:38     INFO -  running event loop
[task 2022-03-14T23:04:38.991Z] 23:04:38     INFO -  xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js | Starting check_remote
[task 2022-03-14T23:04:38.991Z] 23:04:38     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2022-03-14T23:04:38.991Z] 23:04:38     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - true == true

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1759201 - Fix a webext xpcshell test to not stringify really complex objects. r=#extension-reviewers

test_ext_contexts_gc.js calls Assert.ok(context, "..."). That in turn
computes the assert message (even if the assert fails), by calling
JSON.stringify(context).

The context object here is really complex and serialization depends on
the component order because it holds a Cu.Sandbox object among other
stuff. If enumerating a member throws, then we don't get to enumerate
other potentially problematic stuff.

But changing the order of enumeration made it so that we enumerated
nsFocusManager.activeWindow before throwing, which asserts in debug
builds getting my previous patch backed out. Amazing.

Depends on D140975

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9781eea5bfd4
Add a text recognition component. r=dminor,gregtatum
https://hg.mozilla.org/integration/autoland/rev/9174271de7dd
Fix a webext xpcshell test to not stringify really complex objects. r=extension-reviewers,zombie

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9781eea5bfd4
https://hg.mozilla.org/mozilla-central/rev/9174271de7dd