1759242 - Crash in [@ core::result::unwrap_failed | wgpu_core::device::<T>::render_bundle_encoder_finish]

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Andrew McCreight [:mccr8]]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/c0bd4c7a-0089-419c-b49e-57f5b0220309

MOZ_CRASH Reason: called `Result::unwrap()` on an `Err` value: InvalidResource

Top 10 frames of crashing thread:

0 XUL RustMozCrash mozglue/static/rust/wrappers.cpp:18
1 XUL mozglue_static::panic_hook mozglue/static/rust/lib.rs:91
2 XUL core::ops::function::Fn::call library/core/src/ops/function.rs:70
3 XUL std::panicking::rust_panic_with_hook library/std/src/panicking.rs:610
4 XUL std::panicking::begin_panic_handler::{{closure}} library/std/src/panicking.rs:502
5 XUL std::sys_common::backtrace::__rust_end_short_backtrace library/std/src/sys_common/backtrace.rs:139
6 XUL rust_begin_unwind library/std/src/panicking.rs:498
7 XUL core::panicking::panic_fmt library/core/src/panicking.rs:116
8 XUL core::result::unwrap_failed library/core/src/result.rs:1690
9 XUL wgpu_core::device::<impl wgpu_core::hub::Global<G>>::render_bundle_encoder_finish third_party/rust/wgpu-core/src/device/mod.rs:4278

URL in this report is https://austin-eng.com/webgpu-samples/samples/animometer

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Failing unwrap appears to be https://searchfox.org/mozilla-central/rev/efc480f2188fb43c9cccdfd2eef79749a19c20a3/third_party/rust/wgpu-core/src/command/bundle.rs#263

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

This can still be reproduced at the given URL, e.g. https://crash-stats.mozilla.org/report/index/acc1daf1-c609-4142-b6da-0dc3b0220511

Comment 3

[Jim Blandy :jimb]

Taking - this is very close to the code I'm dealing with in bug 1752538.

Comment 4

[Jim Blandy :jimb]

I can reproduce this locally.

Comment 5

[Jim Blandy :jimb]

This is a wgpu-core bug in error handling: https://github.com/gfx-rs/wgpu/issues/2665

Comment 6

[Jim Blandy :jimb]

Pull request for wgpu-core fix: https://github.com/gfx-rs/wgpu/pull/2666

Comment 7

[Jim Blandy :jimb]

This will be fixed by bug 1769633.

Comment 8

[Jim Blandy :jimb]

Verified, this gives an error now due to a WGSL syntax error, and does not crash.